Custom Query (2449 matches)

My /tmp directory was filled with millions of deluge_ticon.xxxxx files, causing the Server to malfunction.

My guess is that it is the same bug as: ​https://dev.deluge-torrent.org/ticket/3167#no4 But that was marked as GTK-UI, but it happened to me with the webUI. So I opened a new ticket.

Deluge 2.0.4

deluge-console 2.0.5 libtorrent: 2.0.5.0 Python: 3.10.4 OS: Linux Arch Linux ARM Shell: Zsh

As mentioned in the Summary, deluge-console crashes with the following traceback:

Traceback (most recent call last):                                                                                                                                                                                 
  File "/usr/bin/deluge-console", line 33, in <module>                                                                                                                                                             
    sys.exit(load_entry_point('deluge==2.0.5', 'console_scripts', 'deluge-console')())
  File "/usr/lib/python3.10/site-packages/deluge/ui/console/__init__.py", line 19, in start
    Console().start()                               
  File "/usr/lib/python3.10/site-packages/deluge/ui/console/console.py", line 164, in start
    return deluge.common.run_profiled(                                                                   
  File "/usr/lib/python3.10/site-packages/deluge/common.py", line 1351, in run_profiled
    return func(*args)                              
  File "/usr/lib/python3.10/site-packages/deluge/ui/console/console.py", line 159, in run
    return c.start_ui()                             
  File "/usr/lib/python3.10/site-packages/deluge/ui/console/main.py", line 164, in start_ui
    wrapper(self.run)                               
  File "/usr/lib/python3.10/curses/__init__.py", line 94, in                                             
 wrapper                                            
    return func(stdscr, *args, **kwds)                                                                   
  File "/usr/lib/python3.10/site-packages/deluge/ui/console/main.py", line 252, in run
    colors.init_colors()                            
  File "/usr/lib/python3.10/site-packages/deluge/ui/console/utils/colors.py", line 110, in init_colors
    counter = define_pair(counter, 'white', 'grey', curses.COLOR_WHITE, 241)
  File "/usr/lib/python3.10/site-packages/deluge/ui/console/utils/colors.py", line 91, in define_pair
    curses.init_pair(counter, fg, bg)                                                                    
ValueError: Color number is greater than COLORS-1 (7).

A quick change in line ​94 of colors.py from:

except curses.error as ex:

to:

except (curses.error, ValueError) as ex:

Allows the program to continue and works as expected but you are welcome to dig into the root cause of the actual issue.

Steps

Create an invalid torrent file (something this is not bencoded) eg

echo "Invalid torrent file format" > /path/to/watch-folder/bad.torrent

Expected outcome

Torrent file should be detected by AutoAdd?, and after failing attempts to add a few times, it should be renamed to bad.torrent.invalid (using existing file failure functionality) and AutoAdd? should continue to monitor the folder.

Actual outcome

Watch folder is disabled in AutoAdd?, and torrent filename is unchanged. Re-enabling the folder in AutoAdd?, just leads to repeated disables.

deluged[112816]: 21:51:20 [ERROR   ][deluge_autoadd.core           :367 ] Disabling "/path/to/watch-folder", error during update: [Failure instance: Traceback: <class 'RuntimeError'>: unexpected end of file in bencoded string
deluged[112816]: /usr/lib/python3/dist-packages/deluge/plugins/AutoAdd-1.8.egg/deluge_autoadd/core.py:108:enable_looping
deluged[112816]: /usr/lib/python3/dist-packages/deluge/plugins/AutoAdd-1.8.egg/deluge_autoadd/core.py:379:enable_watchdir
deluged[112816]: /usr/local/lib/python3.8/dist-packages/twisted/internet/task.py:194:start
deluged[112816]: /usr/local/lib/python3.8/dist-packages/twisted/internet/task.py:239:__call__
deluged[112816]: --- <exception caught here> ---
deluged[112816]: /usr/local/lib/python3.8/dist-packages/twisted/internet/defer.py:151:maybeDeferred
deluged[112816]: /usr/lib/python3/dist-packages/deluge/plugins/AutoAdd-1.8.egg/deluge_autoadd/core.py:278:update_watchdir
deluged[112816]: /usr/lib/python3/dist-packages/deluge/plugins/AutoAdd-1.8.egg/deluge_autoadd/core.py:164:load_torrent
deluged[112816]: ]

Root cause is failure to check data returned from bdecode function. (it return None when decoding fails) (pull request to fix coming shortly)