Opened 8 years ago

Closed 8 years ago

#1112 closed bug (Fixed)

[PATCH] When file name is changed in Add Torrents dialog, file's path info is lost.

Reported by: ankouslash Owned by:
Priority: major Milestone: 1.3
Component: GTK UI Version: 1.3.0_dev
Keywords: Cc:

Description

When rename file under directory in Add Torrent dialog, file is stored outside of the directory.

Steps to reproduce:
1) Open a torrent file includes directory and file (i.e. /dir_A/file_B).
2) Rename file in Add Torrent dialog (e.g. file_B to file_C).

Actual result:
Renamed file_C is stored outside of dir_A.

Platform: Arch Linux
Versions:
deluge trunk r6066
Python 2.6.4

Attachments (2)

add-torrent-dialog-fix-renames.patch (1.2 KB) - added by Ideal 8 years ago.
testtor.torrent (263 bytes) - added by Ideal 8 years ago.
Torrent file to test this issue (try to rename dirlevel1 without a patch above)

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by Ideal

Some more notes about this issue. For me things start to go wrong here when torrent has 3 level nested directory structure. So for example to reproduce torrent should be like this:

top_level_dir/level1_dir/level2_dir/

Then you just can rename any directory in Add Torrents dialog and see the result in the Files tab. Here i see for example if i rename top_level_dir to top_level_dir11 - in the Files tab both and top_level_dir and top_level_dir11 shown at top level for some reason, also level2_dir is missing at all.

comment:2 Changed 8 years ago by Ideal

  • Component changed from core to gtkui
  • Summary changed from When file name is changed in Add Torrents dialog, file's path info is lost. to [PATCH] When file name is changed in Add Torrents dialog, file's path info is lost.
  • Version changed from 1.2.0_dev to 1.3.0_dev

Okay, here is the patch below for this issue at least for what i see wrong here i wrote in the previous comment.

Changed 8 years ago by Ideal

Changed 8 years ago by Ideal

Torrent file to test this issue (try to rename dirlevel1 without a patch above)

comment:3 Changed 8 years ago by johnnyg

  • Milestone set to 1.3.0

comment:4 Changed 8 years ago by johnnyg

  • Resolution set to fixed
  • Status changed from new to closed

This has been fixed in master and will be in 1.3.0.

Note: See TracTickets for help on using tickets.