"Move storage" in deluge-gtk doesn't work

[simonbcn]

deluge-gtk + remote deluged
Error in console:

Traceback (most recent call last):
  File "/usr/local/lib/python2.6/dist-packages/deluge-1.3.900_dev-py2.6.egg/deluge/ui/gtkui/menubar.py", line 353, in _on_response_event
    log.debug("Moving torrents to %s", entry.get_text())
NameError: free variable 'entry' referenced before assignment in enclosing scope

[simonbcn]

I have verified that this does not happen always, sometimes it works well... ?_?

[simonbcn]

Please, can you fix this? It's very annoying and, when this occurs, it's impossible work with gtk-ui.

[negge]

I don't know if it's exactly related to this as I don't currently log the output from deluged, but I know for a fact that you cannot use the "Move storage" feature if the file/folder you're moving or the location you're moving to contains Scandinavian characters (åäö).

[Cas]

i am closing this bug as i see no problems with 1.3 releases.

negge: if your bug still exists could you create a new ticket with details please

[negge]

Actually I just lended my spare harddrive to a friend so I can't test with another filesystem at the moment. I will re-open this bug if I find that switching filesystems doesn't work.

[Cas]

negge please see #1373 as i think this is the same as your problem.

[s0undt3ch]

I've hit this bug too:

[DEBUG   ] 19:33:12 gtkui:267 sent: 7.3 MiB recv: 37.7 MiB
[DEBUG   ] 19:33:12 gtkui:275 sent rate: 8.5 KiB/s recv rate: 16.8 KiB/s
[DEBUG   ] 19:33:22 gtkui:267 sent: 7.3 MiB recv: 37.9 MiB
[DEBUG   ] 19:33:22 gtkui:275 sent rate: 8.4 KiB/s recv rate: 16.6 KiB/s
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/deluge/ui/gtkui/menubar.py", line 351, in _on_response_event
    dialog.hide()
NameError: free variable 'dialog' referenced before assignment in enclosing scope
[DEBUG   ] 19:33:32 gtkui:267 sent: 7.4 MiB recv: 38.1 MiB
[DEBUG   ] 19:33:32 gtkui:275 sent rate: 8.4 KiB/s recv rate: 16.8 KiB/s
[DEBUG   ] 19:33:42 gtkui:267 sent: 7.5 MiB recv: 38.2 MiB
[DEBUG   ] 19:33:42 gtkui:275 sent rate: 8.5 KiB/s recv rate: 16.6 KiB/s

This happens both in the deluge ppa package and in master. The torrent being moved only has ascii chars.

[Cas]

Please describe exactly how to reproduce this error

[Cas]

I think this is a pygtk problem, maybe this one:  https://bugzilla.gnome.org/show_bug.cgi?id=546802

The piece of code referenced has not been altered in 3 years and has no obvious errors in it.

For reference I run Ubuntu 10.10 and my version of python-gobject is 2.21.5

[s0undt3ch]

Replying to Cas:

I think this is a pygtk problem, maybe this one:  https://bugzilla.gnome.org/show_bug.cgi?id=546802 The piece of code referenced has not been altered in 3 years and has no obvious errors in it. For reference I run Ubuntu 10.10 and my version of python-gobject is 2.21.5

Issue is still present in current maverick. What's needed is keep it referenced, here's a proposed patch:

deluge/ui/gtkui/menubar.py

@@ -341 +341 @@
         glade = gtk.glade.XML(
                 pkg_resources.resource_filename("deluge.ui.gtkui",
                                                 "glade/move_storage_dialog.glade"))
-        dialog = glade.get_widget("move_storage_dialog")
-        dialog.set_transient_for(self.window.window)
-        entry = glade.get_widget("entry_destination")
-        entry.set_text(status["save_path"])
+        self.move_storage_dialog = glade.get_widget("move_storage_dialog")
+        self.move_storage_dialog.set_transient_for(self.window.window)
+        self.move_storage_dialog_entry = glade.get_widget("entry_destination")
+        self.move_storage_dialog_entry.set_text(status["save_path"])
         def _on_response_event(widget, response_id):
+            def core_responded(*args):
+                # Delete references
+                del self.move_storage_dialog_entry
+                del self.move_storage_dialog
             if response_id == gtk.RESPONSE_OK:
                 log.debug("Moving torrents to %s", entry.get_text())
-                path = entry.get_text()
-                client.core.move_storage(component.get("TorrentView").get_selected_torrents(), path)
-            dialog.hide()
-        dialog.connect("response", _on_response_event)
-        dialog.show()
+                path = self.move_storage_dialog_entry.get_text()
+                client.core.move_storage(
+                    component.get("TorrentView").get_selected_torrents(),
+                    path
+                ).addCallback(core_responded)
+            self.move_storage_dialog.hide()
+        self.move_storage_dialog.connect("response", _on_response_event)
+        self.move_storage_dialog.show()
+
 
     def on_menuitem_queue_top_activate(self, value):
         log.debug("on_menuitem_queue_top_activate")

Good enough for commit?

[s0undt3ch]

Fixed in master.