Opened 7 years ago

Closed 7 years ago

#1498 closed patch (Fixed)

[PATCH] core.torrent.Torrent.rename_folder adds a forward slash.

Reported by: Hiram Owned by:
Priority: minor Milestone: 1.3.2
Component: Core Version: other (please specify)
Keywords: Cc:

Description

torrent.py adds an unnecessary forward slash to the end of a folder when it gets renamed. This creates a rollover problem when it renames the files in the torrent to match the folder, as it creates a double forward slash.

E.g., "Folder", containing "file.txt", becomes "Folderfile.txt" which creates viewing problems in the GTK client, not sure if it creates a problem in the filesystem though.

The attached patch corrects this.

Attachments (2)

torrent.py-folder-rename.patch (490 bytes) - added by Hiram 7 years ago.
Patch file corrects unnecessary forward slashes.
0002-Fix-1498-On-folder-rename-ensures-trailing-slash-and.patch (1.1 KB) - added by Cas 7 years ago.
Cas' Alternative Patch

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Hiram

Patch file corrects unnecessary forward slashes.

Changed 7 years ago by Cas

Cas' Alternative Patch

comment:1 Changed 7 years ago by Cas

I'm afraid you have removed one problem and created another when a folder name does not have a trailing slash.

I have attached a alternative patch.

comment:2 Changed 7 years ago by Cas

  • Resolution set to fixed
  • Status changed from new to closed

A different fix has been applied to master and 1.3-stable

Note: See TracTickets for help on using tickets.