Opened 7 years ago

Closed 7 years ago

#1517 closed bug (Fixed)

Isohunt urls not loading

Reported by: Cas Owned by: johnnyg
Priority: minor Milestone: 1.3.2
Component: Core Version: 1.3.1
Keywords: url isohunt httpdownloader Cc:

Description

Every other torrent url I've tested works fine but Isohunt ones just don't load.

Change History (7)

comment:1 Changed 7 years ago by Cas

  • Priority changed from major to minor

An example link and the error: http://ca.isohunt.com/download/44648933/big+buck+bunny.torrent

Traceback (most recent call last):
  File "/home/calum/Documents/Coding/Deluge Work/deluge/deluge/ui/web/server.py", line 665, in start
    reactor.run()
  File "/usr/lib/python2.6/dist-packages/twisted/internet/base.py", line 1165, in run
    self.mainLoop()
  File "/usr/lib/python2.6/dist-packages/twisted/internet/base.py", line 1177, in mainLoop
    self.doIteration(t)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/selectreactor.py", line 140, in doSelect
    _logrun(selectable, _drdw, selectable, method, dict)
--- <exception caught here> ---
  File "/usr/lib/python2.6/dist-packages/twisted/python/log.py", line 84, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/usr/lib/python2.6/dist-packages/twisted/python/log.py", line 69, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/usr/lib/python2.6/dist-packages/twisted/python/context.py", line 59, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/lib/python2.6/dist-packages/twisted/python/context.py", line 37, in callWithContext
    return func(*args,**kw)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/selectreactor.py", line 156, in _doReadOrWrite
    self._disconnectSelectable(selectable, why, method=="doRead")
  File "/usr/lib/python2.6/dist-packages/twisted/internet/posixbase.py", line 250, in _disconnectSelectable
    selectable.readConnectionLost(f)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/tcp.py", line 508, in readConnectionLost
    self.connectionLost(reason)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/tcp.py", line 677, in connectionLost
    Connection.connectionLost(self, reason)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/tcp.py", line 519, in connectionLost
    protocol.connectionLost(reason)
  File "/usr/lib/python2.6/dist-packages/twisted/web/client.py", line 156, in connectionLost
    http.HTTPClient.connectionLost(self, reason)
  File "/usr/lib/python2.6/dist-packages/twisted/web/http.py", line 489, in connectionLost
    self.handleResponseEnd()
  File "/usr/lib/python2.6/dist-packages/twisted/web/client.py", line 208, in handleResponseEnd
    PartialDownloadError(self.status)))
  File "/usr/lib/python2.6/dist-packages/twisted/web/client.py", line 443, in noPage
    self.deferred.errback(reason)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 345, in errback
    self._startRunCallbacks(fail)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 410, in _startRunCallbacks
    raise AlreadyCalledError
twisted.internet.defer.AlreadyCalledError:

comment:2 Changed 7 years ago by al.cadd9

  • Component changed from webui to core
  • Summary changed from Isohunt urls not loading with WebUI to Isohunt urls not loading

same problem using the gtkUI

comment:3 Changed 7 years ago by al.cadd9

  • Owner changed from damoxc to johnnyg
  • Status changed from new to assigned

comment:4 Changed 7 years ago by al.cadd9

  • Keywords httpdownloader added

This issue could be resolved using GIO as a fallback. This patch http://dev.deluge-torrent.org/attachment/ticket/1549/deluge-console-add-gio.patch shows a real-world implementation for the console, while this simple script http://pastebin.com/insXbGgN could be used for testing. (thanks mathbr)

comment:5 Changed 7 years ago by Cas

The failure in gtkui for isohunt urls is only when manually adding to 'add url' dialog box. Torrent files and urls clicked in the browser load fine.

For the webui all forms of attempting to add an isohunt torrent fail.

comment:6 Changed 7 years ago by johnnyg

This is due to isohunt returning an incorrect content-length header for compressed files (it sends the original size rather than the compressed size), confusing twisted (which httpdownloader uses) into thinking the connection was closed prematurely.

Isohunt should really fix this issue (there are reports on this from 2005!) however I will commit a fix to handle this in the meantime.

comment:7 Changed 7 years ago by johnnyg

  • Resolution set to fixed
  • Status changed from assigned to closed

This has been fixed in git and will be in the next release.

Note: See TracTickets for help on using tickets.