Opened 7 years ago

Closed 6 years ago

#1567 closed patch (Fixed)

js from plugins does not work with different 'base' setting

Reported by: wump Owned by: damoxc
Priority: minor Milestone: 1.3.2
Component: Web UI Version: 1.3.0_dev
Keywords: Cc:

Description

Javascript files belonging to plugins are sourced from /js instead of a relative path. This causes them to break when a different base path is used. Attached patch fixes this problem.

Attachments (1)

0001-prefix-base-js-for-plugins.patch (1.1 KB) - added by wump 7 years ago.
patch

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by wump

patch

comment:1 Changed 7 years ago by wump

This patch is wrong. Using the relative path will not always work, should query the base explicitly from the Web component. The right fix is here:

https://github.com/laanwj/deluge/commit/f83d858fe3a46122ba842c9a31d6e6a3de055bd3

comment:2 Changed 6 years ago by damoxc

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.