Opened 6 years ago

Closed 4 years ago

Last modified 2 years ago

#1908 closed patch (Fixed)

Minor improvement to bind the webui to an interface

Reported by: friedrichg2 Owned by: damoxc
Priority: minor Milestone: 2.0
Component: Web UI Version: master (git)
Keywords: Cc:

Description

Tested with:

  • python 2.7.1 in linux with master branch
  • python 2.5 in Windows Xp in stable version 1.3.3

Attachments (3)

0001-modified-deluge-ui-web-server.py.patch (2.0 KB) - added by friedrichg2 6 years ago.
patch for server.py
webui.listenaddress.patch (3.3 KB) - added by friedrichg2 6 years ago.
webui.patch (3.2 KB) - added by friedrichg2 6 years ago.
fixed huge mistake…

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by friedrichg2

patch for server.py

comment:1 Changed 6 years ago by andar

This should also include an option for the command line.

comment:2 Changed 6 years ago by Cas

  • Milestone changed from Future to 1.4.0

comment:3 Changed 6 years ago by Cas

I think using the term interface is just as confusing as it is currently in deluged. Since the parameter to supply is an ip address and not an actual ethernet interface.

My suggestion would be for listen-address so in code use listen_address and for the command line option:

-a, --listen-address

This would free up interface for use in the future with the actual interface as a parameter.

Changed 6 years ago by friedrichg2

comment:4 Changed 6 years ago by friedrichg2

I chose interface because that is they way it is called in the twisted API listenTCP --> http://goo.gl/PWw2B and listenSSL --> http://goo.gl/PWw2B

I also think there is no way to bind an ethernet/HW address to a socket using twisted/python or any language I know.

But, I agree that the term can be misleading. (Maybe file a bug in Twisted?).

So here is the patch rewritten using listen-address. Also tested again with config file and command line switch in Linux.

Changed 6 years ago by friedrichg2

fixed huge mistake...

comment:5 Changed 4 years ago by Cas

  • Resolution set to Fixed
  • Status changed from new to closed

Added to develop: [49d4bb496]

comment:6 Changed 2 years ago by Cas

  • Milestone changed from 2.0.x to 2.0
Note: See TracTickets for help on using tickets.