Opened 6 years ago

Closed 5 years ago

Last modified 2 years ago

#1953 closed patch (Fixed)

fix console client flicker on every update

Reported by: terror_macbeth_I Owned by: Cas
Priority: minor Milestone: 2.0
Component: Console UI Version: 1.3.3
Keywords: console curses Cc: nick

Description

The curses call to stdscr.clear() redraws the whole window on every update which causes screen flickering. By replacing the call with one to stdscr.erase() the updates are smooth.

I did not notice a negative impact but did not grasp the whole difference between clear vs. erase either.

Attachments (1)

console noflicker.diff (491 bytes) - added by terror_macbeth_I 6 years ago.
patch to fix screen flicker on screen updates in console ui

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by terror_macbeth_I

patch to fix screen flicker on screen updates in console ui

comment:1 Changed 6 years ago by Cas

  • Milestone changed from Future to 1.3.4
  • Owner set to Cas
  • Status changed from new to accepted
  • Version changed from git master to 1.3.3

I assume this is for 1.3-stable as there is no screen.py in git master.

comment:2 Changed 6 years ago by terror_macbeth_I

Yes, you are right. Sorry for the confusion.

comment:3 Changed 6 years ago by Cas

  • Cc nick added

Fixed in 1.3-stable: 0f962aed

I wonder if this would make a difference to the new console in git master as I noticed the extensive use of stdscr.clear there.

comment:4 Changed 6 years ago by Cas

  • Milestone changed from 1.3.4 to 1.4.0

comment:5 Changed 5 years ago by asmageddon

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixing it this way was not effective in master, but I fixed it in my branch which is now merged into master.

comment:6 Changed 2 years ago by Cas

  • Milestone changed from 2.0.x to 2.0
Note: See TracTickets for help on using tickets.