Ticket #1974 (new patch)

Opened 18 months ago

Last modified 18 months ago

Core shouldn't have to know about the clients in advance

Reported by: jumentous Owned by:
Priority: minor Milestone: 1.4.0
Component: other Version: master (git branch)
Keywords: Cc: jamielennox@…

Description

So, #1971, #1972, #1973 are bugs that were discovered in the trying to fix this point.

I am looking at adding a new UI to deluge, and in the process noticed that the core currently matches the chosen UI and launches the appropriate client. This makes it impossible to add a client developed out of the deluge tree.

This patch modifies setup to export the UI classes as entry points and load the entry point for the class. Details for this method can be found here:  http://aroberge.blogspot.com/2008/12/plugins-part-6-setuptools-based.html and  http://peak.telecommunity.com/DevCenter/PkgResources#locating-plugins

Note that it doesn't actually do a find_plugins yet, it's just moving towards it.

Now i realize that there is already a plugin format for deluge however i thought this more appropriate for something that will be relatively static and can be deployed by rpm/deb.

Obviously, comments/revisions are encouraged.

Attachments

0001-Decouple-GUI-selection-from-core.patch (17.6 KB) - added by jumentous 18 months ago.

Change History

Changed 18 months ago by jumentous

Changed 18 months ago by jumentous

  • cc jamielennox@… added

I've put the branch on github for the patches #1971 #1972 #1973 and this under detach-ui

 https://github.com/jamielennox/deluge/tree/detach-ui

Changed 18 months ago by Cas

  • version changed from other (please specify) to git master
  • type changed from bug to patch
  • milestone changed from Future to 1.4.0
Note: See TracTickets for help on using tickets.