Opened 6 years ago

Last modified 4 months ago

#2047 assigned feature-request

Multi-Edit trackers

Reported by: dus Owned by: Cas
Priority: major Milestone: 2.x
Component: Web UI Version: 1.3.3
Keywords: tracker, edit Cc: bobodod@…, mvseqt2twu@…

Description

Either on the GTK or the WEB ui, you cant change at more then one torrent at time, his tracker list. (Yes, also selecting more then 1).

This sucks 'cause for private trackers you could have to change your passkey (and so the tracker list), for every torrent on the client, but you can't do it one by one.

Anyway, I think it's a bug to change only one torrent if you select more then one.

(By the way, the "move storage" works selecting more than one).

Attachments (2)

0001-Added-a-hack-to-multi-edit-trackers.patch (2.6 KB) - added by bluephoenix47 5 years ago.
git format-patch of mult-edit tracker hack
0001-Edit-trackers-for-all-selected-torrents.patch (2.7 KB) - added by aberaud 4 months ago.
Patch rebased on 1.3-stable

Download all attachments as: .zip

Change History (17)

comment:1 Changed 6 years ago by bobodod

  • Cc bobodod@… added

comment:2 Changed 5 years ago by DoYouWantKarate

  • Cc mvseqt2twu@… added

Changed 5 years ago by bluephoenix47

git format-patch of mult-edit tracker hack

comment:3 Changed 5 years ago by bluephoenix47

I recently wanted to edit a set of (280) torrents to use https instead of http, and to hell with doing that manually.

So I create this hack. I created and tested it on a local 1.3.5 copy, and ported it to the head of the git master branch, so strictly speaking, it's untested.

It has the same semantics as multi-torrent move storage--the initial data comes from the first selected torrent, and the edited data applies to all the selected torrents.

comment:4 Changed 5 years ago by Cas

I've made some changes based on your initial work so that only the trackers that are shared among the selected torrents will be shown. Also added a warning that it will clobber existing trackers when saving.

https://github.com/cas--/Deluge/compare/Feature;2047;EditMultipleTorrentTrackers

This could be added to 1.3-stable for 1.3.6 release.

comment:5 Changed 5 years ago by Cas

  • Milestone changed from 1.3.x to 1.3.6

comment:6 Changed 5 years ago by gazpachoking

If we are going to allow multi-edit trackers, I'd say just show all the trackers from all the torrents rather than filtering down to only the common ones. Or if we want to do only shared trackers, I think this is nicer:

shared_trackers = set.intersection(*(set(status[torrent_id]['trackers']) for torrent_id in status))

Hmm, seems that's only available since python 2.6, do we support 2.5 still?

EDIT: A python 2.5 possibility

shared_trackers = reduce(lambda x, y: x & y, (set(status[torrent_id]['trackers']) for torrent_id in status))

comment:7 Changed 5 years ago by gazpachoking

  • Milestone changed from 1.3.6 to 1.4.0

comment:8 Changed 3 years ago by Cas

Maybe the solution here is not to edit trackers on multiple torrents but to offer a search and replace option such as in the script that I created for a user: https://gist.github.com/cas--/5326335

comment:9 Changed 3 years ago by Cas

  • Owner changed from damoxc to Cas
  • Status changed from new to assigned

comment:10 Changed 3 years ago by bluephoenix47

Search and replace sounds much more robust and less error prone.

comment:11 Changed 2 years ago by Cas

  • Type changed from bug to feature-request

comment:12 Changed 6 months ago by aberaud

That's an important feature when managing many torrents.

If multiple torrents are selected, editing all of them is the expected behavior.

Please merge this. I rebased this patch and it works.

comment:13 Changed 5 months ago by Cas

  • Milestone changed from 2.0.x to 2.x

Milestone renamed

comment:14 Changed 4 months ago by lalomartins

@aberaud can you share a git branch and/or patch? It would both be useful for other users, and increase the chance the devs actually merge it.

Alternatively, I suppose this could be done as a plugin? Anyone has plugin experience?

comment:15 Changed 4 months ago by aberaud

Changed 4 months ago by aberaud

Patch rebased on 1.3-stable

Note: See TracTickets for help on using tickets.