Opened 6 years ago

Closed 6 years ago

#2064 closed bug (Fixed)

Crushed window

Reported by: toniboni88 Owned by: Cas
Priority: trivial Milestone: 1.3.5
Component: GTK UI Version: 1.3.4
Keywords: Cc:

Description (last modified by Cas)

in the torrent creation window, the pane that lists the files or folders, the default is crushed, as in the image attached.

If you widen the window you can see everything correctly. When the close and reopen again but always crushed.

I've Ubuntu Server 11.04, with Deluge 1.3.4 and libtorrent 0.15.9

Attachments (1)

2lcqotz.jpg.png (7.8 KB) - added by toniboni88 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by Cas

  • Owner set to Cas
  • Priority changed from minor to trivial
  • Status changed from new to assigned
  • Type changed from defect to bug

I used a fixed height as a quick fix to the dialog but forgot there might be an issue with other themes.

comment:2 Changed 6 years ago by Cas

Just looked at the code and looks like I put the height request in the wrong widget. Could you test the following change:

diff --git a/deluge/ui/gtkui/glade/create_torrent_dialog.glade b/deluge/ui/gtkui/glade/create_torrent_dialog.glade
index 396bb63..edcc868 100644
--- a/deluge/ui/gtkui/glade/create_torrent_dialog.glade
+++ b/deluge/ui/gtkui/glade/create_torrent_dialog.glade
@@ -72,7 +72,6 @@
                     <property name="spacing">5</property>
                     <child>
                       <widget class="GtkScrolledWindow" id="scrolledwindow1">
-                        <property name="height_request">30</property>
                         <property name="visible">True</property>
                         <property name="can_focus">True</property>
                         <property name="hscrollbar_policy">GTK_POLICY_AUTOMATIC</property>
@@ -80,6 +79,7 @@
                         <property name="shadow_type">GTK_SHADOW_IN</property>
                         <child>
                           <widget class="GtkTreeView" id="treeview_files">
+                            <property name="height_request">30</property>
                             <property name="visible">True</property>
                             <property name="can_focus">True</property>
                             <property name="headers_visible">False</property>

comment:3 Changed 6 years ago by toniboni88

What do I have to go through to test this change?

Changed 6 years ago by toniboni88

comment:4 Changed 6 years ago by Cas

  • Description modified (diff)

If you find that file on your system like this:

locate create_torrent_dialog.glade

This may return two results but one will be a symlink to the other so you can use ls -l to determine which is which.

Create a backup then edit the file so that height_request line is moved to treeview_files widget just below.

comment:5 Changed 6 years ago by toniboni88

Works :)

http://i41.tinypic.com/xlgem8.jpg

comment:6 Changed 6 years ago by Cas

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed 1.3-stable: fe6e9ec467

Note: See TracTickets for help on using tickets.