Opened 6 years ago

Closed 5 years ago

#2086 closed feature-request (Fixed)

Remove workaround for LP #608219

Reported by: Andareed Owned by: Cas
Priority: minor Milestone: 1.3.6
Component: GTK UI Version: 1.3.5
Keywords: indicator Cc:

Description

The problem with sub-menus in indicator menus has been fixed in maverick (note that I only tested on precise).

Attachments (1)

0001-Remove-workaround-for-LP-608219-now-that-it-s-fixed.patch (1.9 KB) - added by Andareed 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by Cas

  • Milestone changed from Future to 1.3.6
  • Owner set to Cas
  • Status changed from new to assigned
  • Version changed from git master to 1.3.5

Good point. I have been meaning to revisit the app indicator to add missing features.

comment:2 Changed 6 years ago by damoxc

Is it fixed in Lucid? If not this shouldn't be applied until Lucid is EOL.

comment:3 follow-up: Changed 6 years ago by damoxc

Or we make an executive decision to no longer support Lucid...

comment:4 Changed 6 years ago by andar

Does leaving the code as-is cause a problem? Or do we need to remove this code to enable proper functionality on this newer version of Ubuntu?

comment:5 in reply to: ↑ 3 Changed 6 years ago by Cas

Replying to damoxc:

Or we make an executive decision to no longer support Lucid...

If needed there is no problem having Lucid specific patch in PPA however by default the app indicator is disabled for Maverick and lower in PPA.

Replying to andar:

Does leaving the code as-is cause a problem? Or do we need to remove this code to enable proper functionality on this newer version of Ubuntu?

Without the submenus the app indicator is quite basic compared to systray.

There are few other issues that need addressed in app indicator but it has never got to the top of my list of things to do.

comment:6 Changed 5 years ago by Cas

I attempted to revert this and implement submenus but there is some very weird bug whereby the items are not returning the correct values so this will need investigated further.

comment:7 Changed 5 years ago by Cas

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed 1.3-stable: 8ffa80c2a2c2

Note: See TracTickets for help on using tickets.