libtorrent 0.16 and torrent moving

[elek]

Running Deluge as a daemon on headless system with Arch linux. With libtorrent 0.16.3 when I trying to move torrent storage I get this:

[DEBUG   ] 15:45:18 core:390 Moving storage ('0b02adfe498dac0e76ea9068646e5b97fcb6d2dd',) to /media/anime/[UTW] Accel World
[WARNING ] 15:45:18 core:393 Error moving torrent 0b02adfe498dac0e76ea9068646e5b97fcb6d2dd to /media/anime/[UTW] Accel World

Downgrading to libtorrent 0.15.10 fixes the issue.

[Cas]

0.16 is supposed to be backward compatible so this bug should be reported to libtorrent bug tracker.

[andar]

Actually, I believe the issue is that we're passing Unicode objects to libtorrent when we should be passing UTF8 encoded byte-strings. There was a change made to make the move_storage method use Unicode to resolve an issue on Windows, but I think it's breaking support on Linux with lt 0.16.

We may need to modify the function to behave differently based on the OS.

[Cas]

Reported on Ubuntu: ​https://bugs.launchpad.net/deluge/+bug/1041415 with suggested workaround.

As a dumb workaround, I had luck with encoding the parameter to UTF-8.

self.handle.move_storage(dest_u.encode("utf-8"))

[Cas]

Fixed in 1.3-stable: ​fc14b008686 and ​3309f59333f

[gazpachoking]

Seems there is still a problem with this. If the dest parameter comes in as an unicode object already it is not encoded to utf-8 before sending to libtorrent. This is compounded by a bug in rencode, which will load strings as unicode objects if they have non-ascii characters, and as byte strings otherwise, no matter whether the string was encoded from a unicode or str object (#2216.)

[gazpachoking]

Ok, think I have a better solution going on in ​this branch. Still needs some testing on linux where wstrings are not enabled though. It also fixes file renaming with unicode characters and torrent creation with unicode paths.

[Cas]

In createtorrent there is another encode(sys.getfilesystemencoding()) in _on_button_file_clicked which needs removed. These changes should fix #2092

[gazpachoking]

Fixed in ​7d88cb1850e