Context Navigation

← Previous Ticket
Next Ticket →

#2174 closed bug (Fixed)

Unable to add torrent via URL

Reported by:	underscor	Owned by:
Priority:	minor	Milestone:	2.x
Component:	Console UI	Version:	master
Keywords:		Cc:

Description

Hi guys! I get the following when attempting to add a torrent via URL. Any ideas?

deluge-console 'add -p "/1/downloads/9c8534b29cce486a571aa76f8225c35ee2e29d6d_wcd_ketsui-extra--dodon_manabu-namiki-_flac_lossless_1644875" "http://bt-download04/torrents.php?action=download&id=1644875&authkey=c28aba95c183165ef8ed2e8ae6a3bbbd&torrent_pass=4np8z7qkzb6dbv8pzdbqoqznvm7avir1"'
/1/"http:/bt-download04/torrents.php?action=download&id=1644875&authkey=c28aba95c183165ef8ed2e8ae6a3bbbd&torrent_pass=4np8z7qkzb6dbv8pzdbqoqznvm7avir1" doesn't exist!

Change History (11)

comment:1 Changed 12 years ago by damoxc

Can you try without the double quotes? I think that my be the issue, when I looked they were still attached to the arguments. Obviously not correct but may allow you to continue with your testing :)

comment:2 Changed 12 years ago by underscor

Hah, that fixed it! Interesting... I assume that's not the intended behaviour, right?

comment:3 Changed 12 years ago by damoxc

I'd imagine not, should be an easy fix though, gimmie a few minutes

comment:4 Changed 12 years ago by damoxc

Actually I'd like to talk to the console ui author before making any changes to see if there's any reason that they're doing it the way they are instead of just using the shlex module. I'll update this ticket when the problem is resolved!

comment:5 Changed 12 years ago by underscor

Awesome, thanks!

comment:6 Changed 12 years ago by damoxc

Hi,

Would you mind testing out the following patch and seeing if it works for you?

deluge/ui/console/main.py

diff --git a/deluge/ui/console/main.py b/deluge/ui/console/main.py
index 55a5c68..052e556 100644

-                      a
 import re
 import locale
+try:
+    import shlex
+except ImportError:
+    shlex = None
 from twisted.internet import defer, reactor
 import deluge.component as component
-…
+ def epilog(self):
     def split(self, text):
         if deluge.common.windows_check():
             text = text.replace('\\', '\\\\')
+        result = re.split(r"(?<!\\) ", text)
+        if shlex:
+            result = shlex.split(text)
+        else:
+            result = re.split(r"(?<!\\) ", text)
         for i, s in enumerate(result):
             result[i] = s.replace(r'\ ', ' ')
         result = filter(lambda s: s != '', result)
-…
+ def write_event(self, s):
                 component.get("LegacyUI").add_line(s, False)
                 self.events.append(s)
         else:
+            print colors.strip_colors(s.encode(self.encoding))
+ No newline at end of file
+            print colors.strip_colors(s.encode(self.encoding))