Opened 5 years ago

Closed 5 years ago

#2240 closed bug (Fixed)

Free disk space indicator is wrong with large capacity drives

Reported by: Ratanak Owned by:
Priority: minor Milestone: 1.3.6
Component: Windows OS Version: 1.3.5
Keywords: Cc:

Description

This commit breaks Deluge's free disk space status bar indicator on Win7 x64.

I have a mapped network store with 2.7tb free but it was showing up as -1.5tb. Fixed it by reverting the changes made. It looks like the normal version of GetDiskFreeSpace messes up larger capacities or it doesn't query mapped network stores properly. The Ex version seems to work with long internally and gives me the correct value.

What was wrong with GetDiskFreeSpaceEx in the first place?

Attachments (1)

common.py.diff (503 bytes) - added by Ratanak 5 years ago.
Patch to revert back to GetDiskFreeSpaceEx?

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by Ratanak

Patch to revert back to GetDiskFreeSpaceEx?

comment:1 Changed 5 years ago by gazpachoking

Hmm, looks like the Windows docs say that GedDiskFreeSpaceEx is the preferred method, I also wonder why this was switched.

comment:2 Changed 5 years ago by Cas

  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from Free disk space indicator is wrong to Free disk space indicator is wrong with large capacity drives

Fixed 1.3-stable: 669d10e6be8e18

Note: See TracTickets for help on using tickets.