Opened 11 years ago
Closed 10 years ago
#2256 closed patch (Fixed)
Indexes aren't updated properly when removing columns
Reported by: | Ratanak | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.3.10 |
Component: | GTK UI | Version: | 1.3.5 |
Keywords: | Cc: | Ratanak |
Description
I've been experimenting with columns in the torrent view and found that the indexes keeping track of which ListStore columns are used by a plugin's view column are not updated properly when another plugin's column is removed. This can lead to the column rendering the wrong data in the view. Default columns are not affected since they have fixed indexes, but this can be an issue for plugin developers.
Attachments (2)
Change History (5)
comment:1 Changed 11 years ago by Ratanak
comment:3 Changed 10 years ago by bro
I've implemented your fix here: https://github.com/bendikro/deluge/tree/1.3.9-column-fix
comment:4 Changed 10 years ago by Cas
- Milestone changed from 1.3.x to 1.3.10
- Resolution set to Fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Fixing the ListStore indexes revealed a deeper issue that better explains why plugin columns were rendering other plugins' column data. It turns out that the TreeViewColumn also needs updating.
When a TreeViewColumn is created, its CellRenderer is given a fixed ListStore column number. Later, when that column number changes (when a column is removed), the CellRenderer continues to use the old column index. For example:
I have added another patch that should resolve the TreeViewColumn index not being updated.