Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#229 closed feature-request (Fixed)

Date Added column?

Reported by: eatsleepgame@… Owned by: andar
Priority: trivial Milestone:
Component: GTK UI Version: 1.1.0_dev
Keywords: Cc:

Description

I think it would be great to have a column that shows when a torrent was added, so one could sort by this, since the queue order is reset after every restart.

Attachments (3)

deluge_patch3 (3.8 KB) - added by Lajnold 9 years ago.
Patch for adding an "Added" column to the torrent view.
deluge_patch4 (4.1 KB) - added by Lajnold 9 years ago.
Patch for adding an "Added" column to the torrent view.
deluge_move_fdate_to_common (2.5 KB) - added by Lajnold 9 years ago.
Move the fdate function in statistics_tab.py to common.py, so that is can be used in listview.py (and others) too.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 9 years ago by bonafemina@…

ticket created 3 months ago but still feature's not implained yet. is it goin' to be added any time soon?

comment:2 Changed 9 years ago by bonafemina@…

  • Component changed from 0.5.x to gtkui
  • Owner changed from markybob to andar
  • Version changed from 0.5.9.0 to 1.1.0_dev

Changed 9 years ago by Lajnold

Patch for adding an "Added" column to the torrent view.

comment:3 Changed 9 years ago by Lajnold

One solution is taking the time the torrent_id.torrent file was last changed, as that is usually the time the torrent was added. This does not require changing the storage format, which makes it an "easy" solution at least. It is not a foolproof solution, as the modification date could be changed by external sources, but from what I have seen, I do not think the client itself changes the .torrent files after they have been added.

Anyhow, I have attached a patch with a possible way of doing it.

comment:4 Changed 9 years ago by Lajnold

After looking more carefully into the code, I see that there is actually a torrents.state file that can be used. Earlier, I had been intent on the fact that saved files were libtorrent based, but now I see that it isn't the case for torrents.state.

I'm posting an updated patch that uses the torrents.state file for storing the "Added" date.

Changed 9 years ago by Lajnold

Patch for adding an "Added" column to the torrent view.

comment:5 Changed 9 years ago by andar

  • Milestone set to 1.1.0
  • Resolution set to fixed
  • Status changed from new to closed

Thanks! This has been been committed in [4142] with some modifications.

comment:6 Changed 9 years ago by Lajnold

Thanks!

The commited code introduces an fdate function in statistics_tab.py, which could also be used in listview.py. I'm attaching a patch that moves fdate to deluge.common.

Is there any preferred way, other than this, for people to send in patches not really solving the current ticket, and instead being general code cleanup, like with the patch I'm now attaching? If that's wished for at all, that is. There is the dev mailing-list, but that doesn't seems to be used really.

Changed 9 years ago by Lajnold

Move the fdate function in statistics_tab.py to common.py, so that is can be used in listview.py (and others) too.

comment:7 Changed 9 years ago by andar

You can send patches/emails to the deluge-dev list.. You can also track me down on irc if you want.

Patch committed [4145]

comment:8 Changed 9 years ago by anonymous

  • Milestone 1.1.0 deleted

Milestone 1.1.0 deleted

Note: See TracTickets for help on using tickets.