Opened 4 years ago

Closed 2 years ago

#2435 closed bug (Fixed)

Edit Tracker dialog only relies on current selection to modify an entry

Reported by: eeppeliteloop Owned by:
Priority: minor Milestone: 1.3.13
Component: GTK UI Version: master (git)
Keywords: Cc:

Description

When editing a single tracker (in the Edit Trackers dialog), the tracker to be modified is the current selection. However it is possible to modify this selection in background since the Edit Tracker dialog (with a single text entry) is not modal. Here are possible bugs:

  1. select an existing tracker
  2. click on Edit
  3. behind the Edit Tracker dialog, select another tracker entry
  4. click on OK in the Edit Tracker dialog

The current selected tracker is modified, not the original one.

More important bug:

  1. select an existing tracker
  2. click on Edit
  3. behind the Edit Tracker dialog, remove all tracker entries so there's no current selection
  4. click on OK in the Edit Tracker dialog

You get:

    self.edit_tracker_entry.hide()
TypeError: iter must be a GtkTreeIter

So either:

  • remember the original tracker name and only modify it if it still exists in the list after pressing OK in Edit Tracker dialog; or
  • make Edit Tracker modal (easier)

Change History (2)

comment:1 Changed 2 years ago by Cas

  • Milestone changed from Future to 1.3.x

comment:2 Changed 2 years ago by Cas

  • Milestone changed from 1.3.x to 1.3.13
  • Resolution set to Fixed
  • Status changed from new to closed

Fixed: [d7e6afb01e]

Note: See TracTickets for help on using tickets.