Opened 9 years ago

Closed 21 months ago

#2716 closed feature-request (Fixed)

Add magnet uri support for tr.x tracker

Reported by: Xuefer Owned by:
Priority: minor Milestone: 2.1.1
Component: Core Version: 1.3.11
Keywords: Cc:

Description

torrents added using magnet link (copy & paste) in WebUI downloads well, but i can see no tracker in the torrent. the magnet link comes trackers looks like: tr.0=... tr.1=..

Change History (8)

comment:1 Changed 9 years ago by Xuefer

magnet:?xt=urn:btih:61611835cc5ffad89fc1a296273df2f6fcdfb359&tr.0=http://tracker.ktxp.com:6868/announce&tr.1=udp://tracker.ktxp.com:6868/announce after adding, verify it with "options -> edit trackers" and/or "Details -> trackers", just no tracker there

comment:2 Changed 9 years ago by Cas

  • Component changed from Web-UI to Core
  • Milestone changed from Future to 2.0
  • Summary changed from tracker not added for magnet links to Add magnet uri support for tr.x tracker
  • Type changed from bug to feature-request

Using tr.0 is not part of the bittorrent spec:

tr is a tracker url, if there is one. If there are multiple trackers, multiple tr entries may be included.

There is nothing explicitly mentioned in the magnet spec about trackers either. Although it appears that transmission have silently added support for this: https://trac.transmissionbt.com/ticket/3341

I am a bit reluctant to add support without clarification that this is an actual part of the magnet spec and as such there are no details on whether .0, .1 etc are supposed to represent trackers tiers. The only details I can find on this relate solely to xt. However since Transmission have started a trend and there is a little ambiguity in magnet uri spec, I guess it should be supported.

As we also pass magnet uris to libtorrent, it will also need to be informed of this addition.

comment:3 Changed 9 years ago by Xuefer

thanks for clarifying this as request. they also accepted the bug report about supporting tr.0 instead of just tr.1 tr.2 etc.

https://trac.transmissionbt.com/ticket/5134 https://trac.transmissionbt.com/changeset/13619

tr.0} tr.1 are good to support because to generate the link a web site may use the code like this: $url = "magnet://....." . http_build_query(array('xt' => ...., 'dn' => ...) + $trackers), see http://php.net/manual/en/function.http-build-query.php multiple tr is impossible for http_build_query function

Version 0, edited 9 years ago by Xuefer (next)

comment:4 Changed 6 years ago by Cas

  • Milestone changed from 2.0 to 2.0.0

Milestone renamed

comment:5 Changed 5 years ago by Cas

  • Milestone changed from 2.0.0 to 2.1.x

Ticket retargeted after milestone closed

comment:6 Changed 2 years ago by Cas

  • Milestone changed from 2.1.x to 2.1.0

Milestone renamed

comment:7 Changed 21 months ago by Cas

  • Milestone changed from 2.1.0 to 2.1.1

Ticket retargeted after milestone closed

comment:8 Changed 21 months ago by Cas

  • Resolution set to Fixed
  • Status changed from new to closed

Originally include via [112a872bc16b8]

Fixed tracker unquoting

Note: See TracTickets for help on using tickets.