Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#635 closed feature-request (Fixed)

Autofocus to password input in webui...

Reported by: dasnyderx@… Owned by: mvoncken
Priority: trivial Milestone:
Component: Web-UI Version: 1.0.6
Keywords: webui login Cc:

Description

Currently, whenever the user goes initially goes to the login page on the web UI, they have to manually change the focus to the password input box (by clicking on the input box or tabbing through the links). Attached, you will find a diff (against the -current version of deluge) to change the focus to the password input box on window load. You will notice from the diff that I have coded the event within a script element on the login page. I looked through the mootools stuff and site, but it appears that the 'addEvents' method is only included with the mootools event package. Since, I didn't see that this mootools package was included with deluge, I therefore hand-coded the focus for the password input box on window load. If you have a better suggestion on how to implement this, I would be glad to hear and implement it.

BTW, you will note that the diff also includes changes to the login failure error message. This is due to the fact that there is a space missing between the comma and the 'try' word. I would also recommend that the error CSS class declaration (in template_style.css) be expanded beyond 200 pixels. The error phrase, "Password is invalid, try again.", is longer than the error class' tiny 200 pixel length.

Attachments (1)

webui_login.diff (738 bytes) - added by dasnyderx@… 6 years ago.
Diff to the login.html page for password auto-focus

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by dasnyderx@…

Diff to the login.html page for password auto-focus

comment:1 Changed 6 years ago by anonymous

  • Resolution set to fixed
  • Status changed from new to closed

Thanks, I like a report with a patch.
fixed in r4340

comment:2 Changed 6 years ago by mvoncken

r4341 , error class set to 400px.

We're in transition from plain js to mootools.
It worked great for webui-ajax, webui-html will use more of mootools & mooui in the future.

comment:3 Changed 6 years ago by mvoncken

Note : fixed in 1.1, not in 1.0.

comment:4 Changed 6 years ago by mvoncken

  • Milestone set to 1.1.0

comment:5 Changed 6 years ago by anonymous

  • Milestone 1.1.0 deleted

Milestone 1.1.0 deleted

Note: See TracTickets for help on using tickets.