Ticket #693 (closed bug)
share ratio limit not respected
| Reported by: | wallfur@… | Owned by: | andar |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.3.0 |
| Component: | core | Version: | 1.2.0 |
| Keywords: | ratio limit upload | Cc: | boteeka |
Description
running on 64 bit ubuntu.
i recently had my 'net connection "shaped" (which caused havoc for my household and our voip phone) because deluge does not respect my share ratio settings.
i already have it set to share more than i receive, disabled time limits (i think?) by setting both time ratio and time to -1, and also set it to stop seeding when the ratio is reached. doing some manual calculations on that current torrent, it is clear deluge has gone way over the share ratio i set, and is still uploading as much as it can, even after setting the upload speed limit for it to 0 or a low value. i think the cause might be that i have not finished downloading yet.
i don't know how you determine when to stop uploading programatically but i have a couple of logic suggestions:
take the greater of 2 measurements of download size - the total of the blocks needed to download selected file(s) in a torrent and the total file bytes actually downloaded. if you're only downloading 2 files out of a torrent with 10 files the ratio should not be based on the size of the full 10 files, this measurement needs to be dynamic to accommodate people adding/removing file selections from a torrent. also measuring the actual file bytes received will prevent people from manipulating upload ratios by "choosing not to download files" after they have already got them.
multiply the download total by the share ratio then just stop uploading altogether when that limit is reached, with 2 exceptions: don't stop in middle of a block's transfer; and, if the user has set their share ratio to < 1 and is sill downloading, allow uploading until ratio has reached 1 to help prevent them leeching.
