Ticket #851 (accepted patch)

Opened 4 years ago

Last modified 3 years ago

Labels can only be lowercase

Reported by: neggelandia@… Owned by: damoxc
Priority: trivial Milestone: 1.4.0
Component: plugin Version: 1.2.3
Keywords: label lowercase Cc:

Description

Scenario:

1. Right-click a label and choose Add Label

2. Enter "UPPERCASE" as name and click OK

What happens:

- The new label will be named "uppercase"

What should happen:

- The new label should be named "UPPERCASE"

Attachments

uppercase_labels.diff (0.9 KB) - added by ianmartin 4 years ago.
Allow upercase letters and spaces in labels

Change History

Changed 4 years ago by ianmartin

Allow upercase letters and spaces in labels

Changed 4 years ago by ianmartin

  • type changed from bug to feature-request
  • summary changed from Labels can only be lowercase to [PATCH] Labels can only be lowercase

Is there a good reason for only allowing lowercase labels. Trivial patch attached for tip of 1.1.0_RC branch

Changed 3 years ago by Cas

  • milestone set to 1.3.0

could this be added to master?

Changed 3 years ago by gazpachoking

Hmm, the label name is also the label ID, so having only lower case labels makes this simpler. I know the flexget and the autoadd plugin rely on labels only being lower case, so changes would have to be made elsewhere as well if this were to be implemented. If it was implemented, I think that the label ID should still be lower case, but the display name should be able to be upper case. This would prevent having 2 different labels such as 'tv' and 'TV'.

Changed 3 years ago by damoxc

I don't think that having the labels case insensitive will be a huge issue, I guess just adding a display name to the plugin would suffice?

Changed 3 years ago by Cas

  • priority changed from minor to trivial
  • version changed from 1.1.5 to 1.2.3
  • type changed from feature-request to patch
  • summary changed from [PATCH] Labels can only be lowercase to Labels can only be lowercase

Changed 3 years ago by damoxc

  • status changed from new to accepted
  • owner changed from andar to damoxc
  • milestone changed from 1.3.0 to 1.4.0
Note: See TracTickets for help on using tickets.