Opened 9 years ago

Last modified 7 months ago

#851 accepted patch

Labels can only be lowercase

Reported by: neggelandia@… Owned by: damoxc
Priority: trivial Milestone: 2.x
Component: Plugin Version: 1.2.3
Keywords: label lowercase Cc:

Description

Scenario:

  1. Right-click a label and choose Add Label
  1. Enter "UPPERCASE" as name and click OK

What happens:

  • The new label will be named "uppercase"

What should happen:

  • The new label should be named "UPPERCASE"

Attachments (1)

uppercase_labels.diff (918 bytes) - added by ianmartin 8 years ago.
Allow upercase letters and spaces in labels

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by ianmartin

Allow upercase letters and spaces in labels

comment:1 Changed 8 years ago by ianmartin

  • Summary changed from Labels can only be lowercase to [PATCH] Labels can only be lowercase
  • Type changed from bug to feature-request

Is there a good reason for only allowing lowercase labels. Trivial patch attached for tip of 1.1.0_RC branch

comment:2 Changed 8 years ago by Cas

  • Milestone set to 1.3.0

could this be added to master?

comment:3 Changed 8 years ago by gazpachoking

Hmm, the label name is also the label ID, so having only lower case labels makes this simpler. I know the flexget and the autoadd plugin rely on labels only being lower case, so changes would have to be made elsewhere as well if this were to be implemented. If it was implemented, I think that the label ID should still be lower case, but the display name should be able to be upper case. This would prevent having 2 different labels such as 'tv' and 'TV'.

comment:4 Changed 8 years ago by damoxc

I don't think that having the labels case insensitive will be a huge issue, I guess just adding a display name to the plugin would suffice?

comment:7 Changed 8 years ago by Cas

  • Priority changed from minor to trivial
  • Summary changed from [PATCH] Labels can only be lowercase to Labels can only be lowercase
  • Type changed from feature-request to patch
  • Version changed from 1.1.5 to 1.2.3

comment:8 Changed 8 years ago by damoxc

  • Milestone changed from 1.3.0 to 1.4.0
  • Owner changed from andar to damoxc
  • Status changed from new to accepted

comment:9 Changed 7 months ago by Cas

  • Milestone changed from 2.0.x to 2.x

Milestone renamed

Note: See TracTickets for help on using tickets.