Changeset d08c3f

Timestamp:

10/31/2019 09:57:33 AM (6 years ago)

Author:

Calum Lind <calumlind+deluge@gmail.com>

Branches:

2.0.x, develop, master

Children:

873700

Parents:

40ebdf

git-author:

Jack O'Sullivan <jackos1998@gmail.com> (09/24/2019 10:32:18 AM)

git-committer:

Calum Lind <calumlind+deluge@gmail.com> (10/31/2019 09:57:33 AM)

Message:

Fix privilege dropping when setting process ownership

os.setgid() should be called to set the GID, and it should be called
before os.setuid() to prevent reinstatement of privileges.

File:

• deluge/argparserbase.py (modified) (2 diffs)

deluge/argparserbase.py

@@ -330 +330 @@
 
             if not common.windows_check():
+                if options.group:
+                    if not options.group.isdigit():
+                        import grp
+
+                        options.group = grp.getgrnam(options.group)[2]
+                    os.setgid(options.group)
                 if options.user:
                     if not options.user.isdigit():
@@ -336 +342 @@
                         options.user = pwd.getpwnam(options.user)[2]
                     os.setuid(options.user)
-                if options.group:
-                    if not options.group.isdigit():
-                        import grp
-
-                        options.group = grp.getgrnam(options.group)[2]
-                    os.setuid(options.group)
 
         return options