Changeset d8746a

Timestamp:

01/26/2022 06:40:16 PM (3 years ago)

Author:

Calum Lind <calumlind+deluge@gmail.com>

Branches:

develop, master

Children:

87ec04

Parents:

7c9a54

git-author:

Chase Sterling <chase.sterling@gmail.com> (01/22/2022 03:06:32 AM)

git-committer:

Calum Lind <calumlind+deluge@gmail.com> (01/26/2022 06:40:16 PM)

Message:

[Core] Return plugin keys with get_torrents_status

When requesting all keys, get_torrents_status was missing plugin added keys
This commit brings the behavior in line with get_torrent_status, and deluge 1.3

Closes: ​https://dev.deluge-torrent.org/ticket/3357
Closes: ​https://github.com/deluge-torrent/deluge/pull/347

File:

• deluge/core/core.py (modified) (1 diff)

deluge/core/core.py

@@ -764 +764 @@
 
     @export
+    @defer.inlineCallbacks
     def get_torrents_status(self, filter_dict, keys, diff=False):
         """
         returns all torrents , optionally filtered by filter_dict.
         """
+        all_keys = not keys
         torrent_ids = self.filtermanager.filter_torrent_ids(filter_dict)
-        d = self.torrentmanager.torrents_status_update(torrent_ids, keys, diff=diff)
-
-        def add_plugin_fields(args):
-            status_dict, plugin_keys = args
-            # Ask the plugin manager to fill in the plugin keys
-            if len(plugin_keys) > 0:
-                for key in status_dict:
-                    status_dict[key].update(
-                        self.pluginmanager.get_status(key, plugin_keys)
-                    )
-            return status_dict
-
-        d.addCallback(add_plugin_fields)
-        return d
+        status_dict, plugin_keys = yield self.torrentmanager.torrents_status_update(
+            torrent_ids, keys, diff=diff
+        )
+        # Ask the plugin manager to fill in the plugin keys
+        if len(plugin_keys) > 0 or all_keys:
+            for key in status_dict:
+                status_dict[key].update(self.pluginmanager.get_status(key, plugin_keys))
+        return status_dict
 
     @export