Changeset e31acf

Timestamp:

11/04/2016 11:54:46 PM (9 years ago)

Author:

Calum Lind <calumlind+deluge@gmail.com>

Branches:

2.0.x, develop, master

Children:

0890cc

Parents:

d0d070

git-author:

Calum Lind <calumlind+deluge@gmail.com> (11/04/2016 11:36:33 PM)

git-committer:

Calum Lind <calumlind+deluge@gmail.com> (11/04/2016 11:54:46 PM)

Message:

[GTKUI] Restart application when switching modes

Location:

deluge/ui/gtkui

Files:

• gtkui.py (modified) (1 diff)
• mainwindow.py (modified) (2 diffs)
• preferences.py (modified) (2 diffs)

deluge/ui/gtkui/gtkui.py

@@ -258 +258 @@
         yield self.shutdown()
 
-        # Modal dialogs can prevent the application exiting so destroy mainwindow
-        # Must do this here to avoid hang when closing with SIGINT (CTRL-C)
+        # The gtk modal dialogs (e.g. Preferences) can prevent the application
+        # quitting, so force exiting by destroying MainWindow. Must be done here
+        # to avoid hanging when quitting with SIGINT (CTRL-C).
         self.mainwindow.window.destroy()
 
         reactor.stop()
+
+        # Restart the application after closing if MainWindow attribute set.
+        if component.get('MainWindow').restart:
+            os.execv(sys.argv[0], sys.argv)
 
     def print_rpc_stats(self):

deluge/ui/gtkui/mainwindow.py

@@ -108 +108 @@
         # UI when it is minimized.
         self.is_minimized = False
+        self.restart = False
 
         self.window.drag_dest_set(gtk.DEST_DEFAULT_ALL, [('text/uri-list', 0, 80)], gtk.gdk.ACTION_COPY)
@@ -201 +202 @@
         return self.main_builder
 
-    def quit(self, shutdown=False):
+    def quit(self, shutdown=False, restart=False):
+        """Quits the GtkUI application.
+
+        Args:
+            shutdown (bool): Whether or not to shutdown the daemon as well.
+            restart (bool): Whether or not to restart the application after closing.
+
         """
-        Quits the GtkUI
-
-        :param shutdown: whether or not to shutdown the daemon as well
-        :type shutdown: boolean
-        """
+
         def quit_gtkui():
             def stop_gtk_reactor(result=None):
+                self.restart = restart
                 try:
                     reactor.callLater(0, reactor.fireSystemEvent, 'gtkui_close')

deluge/ui/gtkui/preferences.py

@@ -702 +702 @@
                                        client.connected() and
                                        client.is_localhost())
-                    component.get('MainWindow').quit(shutdown=shutdown_daemon)
+                    component.get('MainWindow').quit(shutdown=shutdown_daemon, restart=True)
                 else:
                     self.gtkui_config['standalone'] = not new_gtkui_standalone
@@ -709 +709 @@
                     self.builder.get_object('radio_thinclient').set_active(
                         not self.gtkui_config['standalone'])
+            mode = 'Thinclient' if was_standalone else 'Standalone'
             dialog = YesNoDialog(
-                _('Switching client mode...'),
-                _('Your current session will be stopped. Do you wish to continue?')
+                _('Switching Deluge Client Mode...'),
+                _('Do you want to restart to use %s mode?' % mode)
             )
             dialog.run().addCallback(on_response)