Custom Query (2447 matches)

In latest python-setuptools 1.57 there's a metadata change causing the description being added to actual payload of generated PKG-INFO and not as header-field like previously. The metadata-spec states it CAN do this, but always does in my tests when using this version. Whenever enabling a plugin, then will show an error in log/terminal about 'None' not supported as first argument, as now is in payload and not in a 'Description' header field anymore, and per spec returns None in that case. I guess can be changed to check for this circumstance, but I quickly just changed line 1147 in deluge/ui/gtk3/preferences.py from: '

self.builder.get_object('label_plugin_details').set_text(
            plugin_info['Description']
        )

Into instead:

 self.builder.get_object('label_plugin_details').set_text(
            plugin_info['Summary']
        )

Which works for old and new PKG-INFO generated files.

Here's two examples of generated AutoAdd.egg-info/PKG-INFO files from unmodified deluge git clone and built with 'python setup.py bdist_egg', first with latest python-setuptools 1.57, and next with previous python-setuptools 1.56.2(both python3, as on arch, python means python3, and btw using latest python 3.9.5 also):

Metadata-Version: 2.1
Name: AutoAdd
Version: 1.8
Summary: Monitors folders for .torrent files.
Home-page: http://dev.deluge-torrent.org/wiki/Plugins/AutoAdd
Author: Chase Sterling, Pedro Algarvio
Author-email: chase.sterling@gmail.com, pedro@algarvio.me
License: GPLv3
Platform: UNKNOWN

Monitors folders for .torrent files.

Metadata-Version: 2.1
Name: AutoAdd
Version: 1.8
Summary: Monitors folders for .torrent files.
Home-page: http://dev.deluge-torrent.org/wiki/Plugins/AutoAdd
Author: Chase Sterling, Pedro Algarvio
Author-email: chase.sterling@gmail.com, pedro@algarvio.me
License: GPLv3
Description: Monitors folders for .torrent files.
Platform: UNKNOWN

Thanks in advance.

Deluge generates about 110,000 DNS requests per day to the SOCKS 5 proxy I set in the settings (a NordVPN one). It occurs in versions 1.3.15 and 2.0.3.

As title, magnets without metadata aren't restored from state upon restart, when using libtorrent 1.2.11 and above, because of change in resume-saving logic of libtorrent i.e. resume-data saved for magnets even without metadata now, which breaks restoring them upon restart in deluge.

I personally fixed it by this:

diff -urN a/deluge/core/torrentmanager.py b/deluge/core/torrentmanager.py
--- a/deluge/core/torrentmanager.py	2021-04-21 12:44:14.000000000 +0200
+++ b/deluge/core/torrentmanager.py	2021-07-20 19:38:41.819231547 +0200
@@ -1029,6 +1029,7 @@
                 tid
                 for tid, t in self.torrents.items()
                 if t.handle.need_save_resume_data()
+                if t.has_metadata
             )
 
         def on_torrent_resume_save(dummy_result, torrent_id):

Easy quick way to reproduce, is to add a magnet with non-existing info-hash and restart deluge, and as said, need to use libtorrent 1.2.11 or above. (e.g. "magnet:?xt=urn:btih:85bbba4035cca750f681284857f53e405eb41f8d" )

Tested on deluge-2.0.4.dev56 and libtorrent-1.2.14 on arch-linux.

Thanks in advance.