Custom Query (2447 matches)

Hi! I searched on the forums and tickets for this idea and guessed it's not been raised; apologies on the contrary.

A nice feature to have could be priority management based on trackers. I foresee two flavors:

• allowing for global priorities only (as currently implemented). That is, if one set tracker A to be High Priority, then all its torrents get High Priority on; if tracker B is set to Normal Priority, but has one B_1 torrent set to VeryVeryHigh Priority, B_1 will have the priority of leeching over A torrents, although the tracker it belongs to has a lower priority than A's;
• allowing for two hierarchical levels of prioritization: trackers, then torrents within a given tracker. That is, considering the same two trackers with the same priorities rules, B torrents will never have the leeching priority over A torrents. In the same time, if A has several torrents, say A_1 to A_3 with priorities declared as A_1 > A_2 > A_3, then along the fact that A_i torrents have the priority over B torrents, A_1 remains before A_2, A_2 before A_3 in the priority queue.

I'd go for the second option, for it provides the user with a powerful tool when it comes to handle trackers for which leeching/seeding activity is rare but important; for instance private trackers where one strive to build (or at least keep!) a good ratio. But the first flavor may be simpler. Maybe giving the choice as a user preference would be great, but the mechanisms are a bit different in the background, so you may not want to code and manage both… if only this idea interests you to start with :)

I happen to know that the 1.1 branch can filter torrents by tracker, so it could make the implementation easier?

It seems that tracker announces are not obeying the settings for global "connections per second".

This means that, if you have > 1000 torrents, announces fail and, when they fail and reach the max re-announce time, they begin to synchronise. Eventually you end up with all torrents attempting to announce simultaeneously which, obviously, fails.

Expected behaviour:

Tracker connections should also be limited by the "Connections Per Second" setting.

While adding some torrents, I get:

Traceback (most recent call last):
  File "/usr/lib64/python2.5/site-packages/deluge/ui/gtkui/addtorrentdialog.py", line 252, in _on_torrent_changed
    self.update_torrent_options(model.get_value(row, 0))
  File "/usr/lib64/python2.5/site-packages/deluge/ui/gtkui/addtorrentdialog.py", line 322, in update_torrent_options
    self.set_default_options()
  File "/usr/lib64/python2.5/site-packages/deluge/ui/gtkui/addtorrentdialog.py", line 418, in set_default_options
    self.core_config["download_location"])
KeyError: 'download_location'
Traceback (most recent call last):
  File "//usr/lib64/python2.5/site-packages/twisted/python/log.py", line 51, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "//usr/lib64/python2.5/site-packages/twisted/python/log.py", line 36, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "//usr/lib64/python2.5/site-packages/twisted/python/context.py", line 59, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "//usr/lib64/python2.5/site-packages/twisted/python/context.py", line 37, in callWithContext
    return func(*args,**kw)
--- <exception caught here> ---
  File "//usr/lib64/python2.5/site-packages/twisted/internet/gtk2reactor.py", line 200, in _doReadOrWrite
    why = source.doRead()
  File "//usr/lib64/python2.5/site-packages/twisted/internet/tcp.py", line 362, in doRead
    return self.protocol.dataReceived(data)
  File "/usr/lib64/python2.5/site-packages/deluge/ui/gtkui/ipcinterface.py", line 44, in dataReceived
    process_args(data)
  File "/usr/lib64/python2.5/site-packages/deluge/ui/gtkui/ipcinterface.py", line 150, in process_args
    component.get("AddTorrentDialog").add_from_files([os.path.abspath(arg)])
  File "/usr/lib64/python2.5/site-packages/deluge/ui/gtkui/addtorrentdialog.py", line 195, in add_from_files
    self.set_default_options()
  File "/usr/lib64/python2.5/site-packages/deluge/ui/gtkui/addtorrentdialog.py", line 418, in set_default_options
    self.core_config["download_location"])
exceptions.KeyError: 'download_location'

This seems to only happen if I try to add multiple torrents at the same time.