Custom Query (2449 matches)

In thin client mode, the shutdown routine does not have to do much, but in classic mode, all the components have to be shut down properly before closing.

There are two separate issues as far as I've found.

GTKUI component shutdown after reactor is stopped

When closing GTKUI main window (​mainwindow.py#L227 ) the reactor is stopped. The result is that this call to reactor.run() returns: ​gtkui.py#L246

The call to self.shutdown() on the next line (​gtkui.py#L247) in turn calls component.stop() and component.shutdown(), which is completely broken, as the reactor is no longer running which means async events like deferreds cannot be processed.

The reason the shutdown procedure in classic mode works anyways as that the daemon has addSystemEventTrigger("before", "shutdown", self._shutdown) which calls component.shutdown(): ​daemon.py#L155

SIGINT stops reactor breaking components shutdown

Running GTKUI in terminal and trying to close with CTRL-C does not work very good. The process hangs and needs multiple signals to close, and sometimes doesn't even close at all and needs explicit call to kill.

The problem is that the reactor closes (reactor.run() ends) resulting in deferreds from component.close/component.shutdown call not being fired.

Here is what im seeing.

Torrents get added to watch folder. Only one torrent gets added to the session. Even with copy torrent to folder none of the torrent files get moved. After some time the watch folder will get disabled then if you re-enable it it does the same thing one gets added no files moved disables itself after some time. Torrents are fine as they can be manually added.

How to Reproduce

While doing a POST operation on /ticket/2474, Trac issued an internal error.

(please provide additional details here)

Request parameters:

{u'__FORM_TOKEN': u'7ab1f959df4840603f2f4d32',
 u'action': u'resolve',
 u'action_resolve_resolve_resolution': u'Invalid',
 u'comment': u'',
 u'field_component': u'Core',
 u'field_keywords': u'',
 u'field_milestone': u'2.0.x',
 u'field_priority': u'minor',
 u'field_summary': u'Replace add_torrent with async_add_torrent',
 u'field_type': u'patch',
 u'field_version': u'develop (git)',
 'id': u'2474',
 u'replyto': u'',
 u'sfp_email': u'',
 u'sfph_mail': u'',
 u'start_time': u'1404732159706907',
 u'submit': u'Submit changes',
 u'view_time': u'1404732159706907'}

User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.75 Safari/537.36

System Information

System information not available

Enabled Plugins

Plugin information not available

Python Traceback

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/trac/web/main.py", line 554, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.7/site-packages/trac/web/main.py", line 247, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.7/site-packages/trac/ticket/web_ui.py", line 182, in process_request
    return self._process_ticket_request(req)
  File "/usr/lib/python2.7/site-packages/trac/ticket/web_ui.py", line 625, in _process_ticket_request
    self._do_save(req, ticket, action)
  File "/usr/lib/python2.7/site-packages/trac/ticket/web_ui.py", line 1357, in _do_save
    replyto=req.args.get('replyto'))
  File "/usr/lib/python2.7/site-packages/trac/ticket/model.py", line 369, in save_changes
    listener.ticket_changed(self, comment, author, old_values)
  File "build/bdist.linux-x86_64/egg/tracext/ircannouncer/listener.py", line 57, in ticket_changed
    self.notify('ticket', values)
  File "build/bdist.linux-x86_64/egg/tracext/ircannouncer/listener.py", line 39, in notify
    self.bot.ircannouncer.notify(type, values)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1233, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1581, in __request
    allow_none=self.__allow_none)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1086, in dumps
    data = m.dumps(params)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 633, in dumps
    dump(v, write)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 655, in __dump
    f(self, value, write)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 736, in dump_struct
    dump(v, write)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 655, in __dump
    f(self, value, write)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 736, in dump_struct
    dump(v, write)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 647, in __dump
    raise TypeError, "cannot marshal %s objects" % type(value)
TypeError: cannot marshal <class 'trac.util.text.Empty'> objects