Custom Query (2449 matches)

Problem

Deluge creates the necessary parent directories of it. However, it does not own the parent directory of the torrent output and thus should not manage it. Creating it is being overly helpful and the problems with auto-creating it include:

a) The parent directory may intentionally be missing

b) Deluge may create the directory with the wrong permissions

Steps to reproduce

1) Download torrent

2) Exit Deluge

3) Move said torrent and delete torrent's parent directory

4) Open Deluge

5) Deluge will create the parent directory and re-download the the torrent

Example

I had all torrents saved in a path like /storage/data/torrents/. (Eg: /storage/data/torrents/TORRENT_NAME.) /storage/data was a mountpoint for another filesystem. I quit Deluge, unmounted /storage/data, and rebooted. Deluge was set to auto-start on boot and it created /storage/data/torrents and then started to re-download everything. This both filled up the filesystem for /storage and caused undesired leeching.

Desired behavior

If the parent directory for a torrent is missing Deluge should not create it and instead fail to proceed.

1. In deluge/ui/common.py, use some code to guess a encoding, and use the encoding to convert the mbcs string to utf8 string

self.__m_name = decode_string(self.__m_metadata["info"]["name"], self.encoding)

but why not:

self.__m_name = self.__m_metadata["info"]["name.utf-8"]

field "XXXX" is a mbcs, but field "XXXX.utf-8" is just a utf8!

2. for f in self.__m_metadata["info"]["files"]:
       self.__m_files.append({
           'path': decode_string(os.path.join(prefix, *f["path"])),
           'size': f["length"],
           'download': True
       })
   

here "prefix" is already a utf8, but f[ "path" ] is a mbcs yet, so os.path.join is invalid

I have an issue when closing and reloading deluged on OSX, when using the pre-compiled Deluge.app distro, which causes all torrents to be reloaded in Paused state. Also, for torrents that I have used flexget and changed the file names, these are forgotten and the original file names are remember. This means when resuming the torrent, the files start re-downloading again.

I have compared my OSX setup to my Ubuntu setup and it appears the torrents.fastresume file is not being created.

I have the following entry in the deluged.log:

[DEBUG   ] 15:32:49 torrentmanager:747 Opening torrents fastresume file for load.
[WARNING ] 15:32:49 torrentmanager:753 Unable to load fastresume file: [Errno 2] No such file or directory: '/Users/xxxx/.config/deluge/state/torrents.fastresume'

torrents.state is present in the folder along with the torrent files.

When I run deluged from the command line I get the error below which calls out save_resume_data_alert numerous times. I am not sure if this is therefore related:

/Applications/Deluge.app/Contents/Resources/lib/python/twisted/internet/_sslverify.py:184: UserWarning: You do not have the service_identity module installed. Please install it from <https://pypi.python.org/pypi/service_identity>. Without the service_identity module and a recent enough pyOpenSSL tosupport it, Twisted can perform only rudimentary TLS client hostnameverification.  Many valid certificate/hostname mappings may be rejected.
Unhandled Error
Traceback (most recent call last):
  File "/Applications/Deluge.app/Contents/Resources/lib/python2.7/deluge-1.3.10-py2.7.egg/deluge/main.py", line 230, in start_daemon
    Daemon(options, args)
  File "/Applications/Deluge.app/Contents/Resources/lib/python2.7/deluge-1.3.10-py2.7.egg/deluge/core/daemon.py", line 171, in __init__
    reactor.run()
  File "twisted/internet/base.pyc", line 1192, in run
    
  File "twisted/internet/base.pyc", line 1201, in mainLoop
    
--- <exception caught here> ---
  File "twisted/internet/base.pyc", line 824, in runUntilCurrent
    
  File "/Applications/Deluge.app/Contents/Resources/lib/python2.7/deluge-1.3.10-py2.7.egg/deluge/core/torrentmanager.py", line 1088, in on_alert_save_resume_data
    self.resume_data[torrent_id] = lt.bencode(alert.resume_data)
Boost.Python.ArgumentError: Python argument types in
    None.None(save_resume_data_alert)
did not match C++ signature:
    None(libtorrent::save_resume_data_alert {lvalue})
Unhandled Error
Traceback (most recent call last):
  File "/Applications/Deluge.app/Contents/Resources/lib/python2.7/deluge-1.3.10-py2.7.egg/deluge/main.py", line 230, in start_daemon
    Daemon(options, args)
  File "/Applications/Deluge.app/Contents/Resources/lib/python2.7/deluge-1.3.10-py2.7.egg/deluge/core/daemon.py", line 171, in __init__
    reactor.run()
  File "twisted/internet/base.pyc", line 1192, in run
    
  File "twisted/internet/base.pyc", line 1201, in mainLoop

I have also tried stopping the daemon from the gtk to check if it was something to do with graceful exiting and this did not help.

As you can imagine not being able to restart deluged is a tad hindering. I hope someone can help :)