Custom Query (2447 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (493 - 495 of 2447)

Ticket Resolution Summary Owner Reporter
#2733 Fixed torrentmanager.py : on_alert_performance - UnicodeDecodeError Bro
Description

The commit Fix #1466 : Performance warning: Send Buffer Watermark produces this error

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/logging/__init__.py", line 882, in emit
    stream.write(fs % msg.encode("UTF-8"))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 95: ordinal not in range(128)
Logged from file torrentmanager.py, line 1212
#2738 Fixed Illegal argument to libtorrent set_max_connections Bro Bro
Description

When testing a debug build of libtorrent I noticed that it fails on an assert statement that tests for valid input to the torrent_handle.set_max_connections

Libtorrent docs says that

This must be at least 2. The default is unlimited number of connections. If -1 is given to the function, it means unlimited.

During startup, deluge passes 0 to this function for some of the torrents. Oddly enough, lt actually treats 0 and -1 equally:

if (limit <= 0) limit = (1<<24)-1;

I'm not sure what really happens when passing in 1.

There are two different asserts:

set_max_connections (torrent_handle.cpp)

TORRENT_ASSERT_PRECOND(max_connections >= 2 || max_connections == -1);

set_max_connections (torrent.cpp)

TORRENT_ASSERT(limit >= -1);

This could indicate that it's only a bug in the lt doc and the assert in torrent_handle.cpp, i.e., 1 and 0 are also valid values.

#2755 WorksForMe UnicodeWarning: torrentmanager.py (download_location" != "move_completed_path" Bro
Description

Got this on develop (9726481fb4a31a20ab9b79b804ae20aa72cafc7a)

/home/bro/programmer/deluge/workdirs/develop-running/deluge/core/torrentmanager.py:917: UnicodeWarning: Unicode unequal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  torrent.options["download_location"] != torrent.options["move_completed_path"]:
Batch Modify
Note: See TracBatchModify for help on using batch modify.
Note: See TracQuery for help on using queries.