Custom Query (2447 matches)

In thin client mode, the shutdown routine does not have to do much, but in classic mode, all the components have to be shut down properly before closing.

There are two separate issues as far as I've found.

GTKUI component shutdown after reactor is stopped

When closing GTKUI main window (​mainwindow.py#L227 ) the reactor is stopped. The result is that this call to reactor.run() returns: ​gtkui.py#L246

The call to self.shutdown() on the next line (​gtkui.py#L247) in turn calls component.stop() and component.shutdown(), which is completely broken, as the reactor is no longer running which means async events like deferreds cannot be processed.

The reason the shutdown procedure in classic mode works anyways as that the daemon has addSystemEventTrigger("before", "shutdown", self._shutdown) which calls component.shutdown(): ​daemon.py#L155

SIGINT stops reactor breaking components shutdown

Running GTKUI in terminal and trying to close with CTRL-C does not work very good. The process hangs and needs multiple signals to close, and sometimes doesn't even close at all and needs explicit call to kill.

The problem is that the reactor closes (reactor.run() ends) resulting in deferreds from component.close/component.shutdown call not being fired.

Loading some torrents gives the error "invalid bencoded value (data after valid prefix)" caused by upstream fix to bencoding.py (​https://github.com/deluge-torrent/deluge/commit/b193d874990e8c572719346e352a2b48c48de723#diff-05121b30645f235ea5b628b984da8dbeR73)

The attached torrent will produce this error.

The current config system supports registering migration functions to migrate old configs to new formats. I migration function will migrate from earlier file format versions resulting in a new config with a higher file version.

If an existing config file does not exist, the config is populated with the default values, however, there is no way to indicate which versions the default values correspond to. The result is that the file version is set to 1 for fresh configs, before the migration functions are called. This requires the default config dict to never change, in order to be compatible with what the migration functions expect.

A solution to this is to add a parameter to specify the file version of the default config dict so that when a config file does not exist on disk, the migration functions are not run because the config file format will already be the latest version.