Custom Query (2449 matches)

I tested deluge against this tracker ​https://www.sixxs.net/tools/tracker/ 0.6svn hung with: "Tracker Status: Announce Sent"

The 0.5.8.9 client says: Alarm: SixXS IPv6 BitTorrent Tracker: This tracker only serves IPv6 clients, you are coming from x.x.x.x (HTTP-Code=400, Anzahl in der Reihe=3)

Deluge only send a ipv4 announce.

I 'fixed' (I think) a bug in deluge-console. Please how may I submit it for approval / checkin? Here is the stacktrace:

16:58:57.792 [ERROR   ][deluge.ui.console.modes.basemode                      :1207] 'ascii' codec can't encode character u'\xf9' in position 15: ordinal not in range(128)
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0b2.dev141-py2.7.egg/deluge/ui/console/modes/basemode.py", line 210, in doRead
    self.read_input()
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0b2.dev141-py2.7.egg/deluge/ui/console/modes/torrentlist/torrentlist.py", line 286, in read_input
    self.minor_mode.handle_read(c)
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0b2.dev141-py2.7.egg/deluge/ui/console/modes/torrentlist/search_mode.py", line 195, in handle_read
    self.torrentlist.refresh([])
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0b2.dev141-py2.7.egg/deluge/ui/console/modes/torrentlist/torrentlist.py", line 223, in refresh
    self.torrentview.update_torrents(lines)
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0b2.dev141-py2.7.egg/deluge/ui/console/modes/torrentlist/torrentview.py", line 325, in update_torrents
    trim=False, scr=self.torrentlist.torrentview_panel,
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0b2.dev141-py2.7.egg/deluge/ui/console/modes/basemode.py", line 160, in add_string
    return add_string(row, string, screen, self.encoding, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0b2.dev141-py2.7.egg/deluge/ui/console/modes/basemode.py", line 290, in add_string
    screen.addstr(row, col, string, color)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf9' in position 15: ordinal not in range(128)

Here is my proposed fix:

~/deluge $ git diff deluge/ui/console/modes/basemode.py
diff --git a/deluge/ui/console/modes/basemode.py b/deluge/ui/console/modes/basemode.py
index 6226d1bc1..804ccdb42 100644
--- a/deluge/ui/console/modes/basemode.py
+++ b/deluge/ui/console/modes/basemode.py
@@ -287,6 +287,7 @@ def add_string(row, fstring, screen, encoding, col=0, pad=True, pad_char=' ', tr
                 string = string[0:remaining_chrs]

         try:
+            string = string.encode( encoding )
             screen.addstr(row, col, string, color)
         except curses.error as ex:
             # Ignore exception for writing offscreen.[/code]

Thanks

Patrick

Built deluge from develop on archlinux. Install and start the daemon with systemctl. Start deluge-console. The local daemon is not shown as contactable.

The log shows:

14:47:38.112 [WARNING ][deluge.transfer :136 ] Failed to decompress (25 bytes) and load serialized data with rencode: loads() got an unexpected keyword argument 'decode_utf8'

Running 'python2', importing rencode and calling loads() manually it does accept the 'decode_utf8' keyword.

If I use inspect in transfer.py to show in the log the function signature for loads() it says: ArgSpec(args=x, varargs=None, keywords=None, defaults=None) which does not match the behavior in the interactive session ie no 'decode_utf8' keyword param.

There is a bug against rencode on github which appears to be the same issue: ​https://github.com/aresch/rencode/issues/15

I note that the call to rencode.dumps() in transfer_message() in transfer.py does not do any utf8 encoding, so I tried just removing the 'decode_utf8=True' arg, but I get: 9:29:29.127 [INFO ][deluge.core.rpcserver :171 ] Deluge Client connection made from: 127.0.0.1:54980 19:29:29.155 [INFO ][deluge.core.rpcserver :197 ] Deluge client disconnected: Connection to the other side was lost in a non-clean fashion: Connection lost.

I may be unable to access the internet in the next week (China!). Apologies for any delay in responding to updates on this.