Custom Query (2447 matches)

Console ui crashes then I try to list options for add command autocomplete and directory contains unicode filenames, i.e.:

add /path/to/directory/with/unicode/entries/ <TAB> <TAB>

Traceback:

[ERROR   ] 23:17:28 screen:300 'ascii' codec can't decode byte 0xd0 in position 13: ordinal not in range(128)
Traceback (most recent call last):
  File "/home/nullie/work/deluge/trunk/deluge/ui/console/screen.py", line 298, in doRead
    self._doRead()
  File "/home/nullie/work/deluge/trunk/deluge/ui/console/screen.py", line 337, in _doRead
    self.input, self.input_cursor = self.tab_completer(self.input, self.input_cursor, second_hit)
  File "/home/nullie/work/deluge/trunk/deluge/ui/console/main.py", line 377, in tab_completer
    self.write(match)
  File "/home/nullie/work/deluge/trunk/deluge/ui/console/main.py", line 268, in write
    self.screen.add_line(line, not self.batch_write)
  File "/home/nullie/work/deluge/trunk/deluge/ui/console/screen.py", line 193, in add_line
    line_length = colors.get_line_length(line)
  File "/home/nullie/work/deluge/trunk/deluge/ui/console/colors.py", line 129, in get_line_length
    line = line.encode(encoding, "replace")
UnicodeDecodeError: 'ascii' codec can't decode byte 0xd0 in position 13: ordinal not in range(128)

That happens because os.listdir in deluge/ui/console/commands/add.py:94 gets encoded string, so it returns encoded strings as result, and screen.py doesn't handle encoded strings.

I could fix this, but don't know where should I do decoding (or make screen accept encoded strings).

Say I have 5 torrents in queue to download and I've got the webui explicitly sorting on the queue position column. Should I change the position of a torrent (say, moving the last in the queue to the first), the rows don't resort, resulting in a list like the following:

2 3 4 5 1

This works fine in the GTKui and presumably the console (haven't checked).

deluge-console's add command will cause a crash when tab-completing a directory that does not exist.

For instance, entering this into deluge-console will cause a crash:

add non-existing-dir/some-file[TAB]

add's tab-complete method will try to list the files in "non-existing-dir/", but throw an error because the directory does not exist.

I have attached a (very small) patch to fix the issue.