Custom Query (2449 matches)

$ deluge-console "config -s allow_remote True; config allow_remote"
Setting allow_remote to True..
Configuration value successfully updated.
  allow_remote: False

Would expect this to return True but requires an separate step:

$ deluge-console "config allow_remote"
  allow_remote: True

Optimized torrent.get_status by keeping track of if the torrent status has been updated since last call. If not, use the the previous values instead of calling the status functions.

I've tested loading deluged with 1000 torrents and connecting thin client and leaving it running for 2 minutes. The number of calls to get_status is around 250000 Current get_status used a total of 15 seconds CPU, while this version used 6 seconds. According to cProfile the average runtime is reduced from 60 to 20 microseconds.

The downside is that the code is a bit more verbose.

​https://github.com/bendikro/deluge/commits/develop-torrent-get-status-speedup

Problem

Deluge creates the necessary parent directories of it. However, it does not own the parent directory of the torrent output and thus should not manage it. Creating it is being overly helpful and the problems with auto-creating it include:

a) The parent directory may intentionally be missing

b) Deluge may create the directory with the wrong permissions

Steps to reproduce

1) Download torrent

2) Exit Deluge

3) Move said torrent and delete torrent's parent directory

4) Open Deluge

5) Deluge will create the parent directory and re-download the the torrent

Example

I had all torrents saved in a path like /storage/data/torrents/. (Eg: /storage/data/torrents/TORRENT_NAME.) /storage/data was a mountpoint for another filesystem. I quit Deluge, unmounted /storage/data, and rebooted. Deluge was set to auto-start on boot and it created /storage/data/torrents and then started to re-download everything. This both filled up the filesystem for /storage and caused undesired leeching.

Desired behavior

If the parent directory for a torrent is missing Deluge should not create it and instead fail to proceed.