Custom Query (2449 matches)

When a torrent is manually added, and the user types in a custom destination path, it makes no sense to tick the "Options - Move Completed" box in the torrent's options.

Example: Preferences - Default download path: ~/Downloads/incoming/, Move completed downloads to: ~/Downloads/complete/

Now the user adds a torrent, and the target path field of course defaults to ~/Downloads/incoming/, but the user instead types /storage/ and adds it like that.

The user has made the choice of where they want the file. Therefore, the "Options - Move Completed" box for that torrent should not be ticked, since the user obviously knows where they want the file to be placed.

The select reactor has issues with more than 1024 file descriptors, which leads to errors like this when having a large number of connections. I'm not sure what the best path to take in this situation is. Either we could integrate with twistd, which does it's own intelligent reactor selection, or write logic to determine whether we're on Linux, and if so, opt for the poll() or epoll() reactor, and select() otherwise.

Traceback (most recent call last):

File "/usr/lib/pymodules/python2.6/deluge/main.py", line 226, in start_daemon

Daemon(options, args)

File "/usr/lib/pymodules/python2.6/deluge/core/daemon.py", line 176, in init

reactor.run()

File "/usr/lib/python2.6/dist-packages/twisted/internet/base.py", line 1170, in run

self.mainLoop()

File "/usr/lib/python2.6/dist-packages/twisted/internet/base.py", line 1182, in mainLoop

self.doIteration(t)

--- <exception caught here> ---

File "/usr/lib/python2.6/dist-packages/twisted/internet/selectreactor.py", line 104, in doSelect

[], timeout)

exceptions.ValueError: filedescriptor out of range in select() Unhandled error in Deferred: Traceback (most recent call last):

File "/usr/lib/python2.6/dist-packages/twisted/internet/base.py", line 1031, in connectionFailed

self.factory.clientConnectionFailed(self, reason)

File "/usr/lib/python2.6/dist-packages/twisted/web/client.py", line 350, in clientConnectionFailed

self.deferred.errback(reason)

File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 307, in errback

self._startRunCallbacks(fail)

File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 354, in _startRunCallbacks

self._runCallbacks()

--- <exception caught here> ---

File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 371, in _runCallbacks

self.result = callback(self.result, *args, kw)

File "/usr/lib/pymodules/python2.6/deluge/core/rpcserver.py", line 316, in on_fail

sendError()

File "/usr/lib/pymodules/python2.6/deluge/core/rpcserver.py", line 252, in sendError

"".join(traceback.format_tb(exceptionTraceback)))

File "/usr/lib/pymodules/python2.6/deluge/core/rpcserver.py", line 196, in sendData

self.transport.write(zlib.compress(rencode.dumps(data)))

File "/usr/lib/pymodules/python2.6/deluge/rencode.py", line 391, in dumps

encode_func[type(x)](x, r)

File "/usr/lib/pymodules/python2.6/deluge/rencode.py", line 338, in encode_list

encode_func[type(i)](i, r)

File "/usr/lib/pymodules/python2.6/deluge/rencode.py", line 338, in encode_list

encode_func[type(i)](i, r)

exceptions.KeyError: <type 'instance'>

As of 1.3.5 deluge makes a copy of every torrent in the state folder under AppData when it is loaded. I don't believe this is efficient when the option to store torrents in a separate directory is turned on.

Another issue I have noticed is that if you are loading a torrent from the same directory as the directory set to copy your .torrent files to it will replace the existing file instead of realizing that the file is already in the right place.

Running deluge version 1.3.5 with libtorrent 0.16.1 on win32