Custom Query (2449 matches)

In thin client mode, the shutdown routine does not have to do much, but in classic mode, all the components have to be shut down properly before closing.

There are two separate issues as far as I've found.

GTKUI component shutdown after reactor is stopped

When closing GTKUI main window (​mainwindow.py#L227 ) the reactor is stopped. The result is that this call to reactor.run() returns: ​gtkui.py#L246

The call to self.shutdown() on the next line (​gtkui.py#L247) in turn calls component.stop() and component.shutdown(), which is completely broken, as the reactor is no longer running which means async events like deferreds cannot be processed.

The reason the shutdown procedure in classic mode works anyways as that the daemon has addSystemEventTrigger("before", "shutdown", self._shutdown) which calls component.shutdown(): ​daemon.py#L155

SIGINT stops reactor breaking components shutdown

Running GTKUI in terminal and trying to close with CTRL-C does not work very good. The process hangs and needs multiple signals to close, and sometimes doesn't even close at all and needs explicit call to kill.

The problem is that the reactor closes (reactor.run() ends) resulting in deferreds from component.close/component.shutdown call not being fired.

$ deluge

23:08:11.145 [ERROR   ][deluge.pluginmanagerbase               :144 ] Component already registered with name GtkPlugin.AutoAdd
23:08:11.145 [ERROR   ][deluge.pluginmanagerbase               :144 ] Component already registered with name GtkPlugin.Stats
23:08:11.145 [ERROR   ][deluge.pluginmanagerbase               :144 ] Component already registered with name GtkPlugin.WebUi
23:08:11.146 [ERROR   ][deluge.pluginmanagerbase               :144 ] Component already registered with name GtkPlugin.Blocklist
23:08:11.146 [ERROR   ][deluge.pluginmanagerbase               :144 ] Component already registered with name GtkPlugin.Label
Unhandled Error
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0.dev603-py2.7.egg/deluge/core/daemon_entry.py", line 121, in run_daemon
    daemon.start()
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0.dev603-py2.7.egg/deluge/core/daemon.py", line 144, in start
    reactor.run()
  File "/usr/lib/python2.7/dist-packages/twisted/internet/base.py", line 1194, in run
    self.mainLoop()
  File "/usr/lib/python2.7/dist-packages/twisted/internet/base.py", line 1203, in mainLoop
    self.runUntilCurrent()
--- <exception caught here> ---
  File "/usr/lib/python2.7/dist-packages/twisted/internet/base.py", line 825, in runUntilCurrent
    call.func(*call.args, **call.kw)
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0.dev603-py2.7.egg/deluge/core/torrentmanager.py", line 408, in on_add_torrent_alert
    d, options, state, filename, magnet, resume_data, filedump, save_state = self.torrents_loading.pop(torrent_id)
exceptions.KeyError: 'd65db24766e6cf2244a7d35af524ecff66617b75'

23:09:09.626 [CRITICAL][twisted                         :154 ] Unhandled Error
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0.dev603-py2.7.egg/deluge/core/daemon_entry.py", line 121, in run_daemon
    daemon.start()
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0.dev603-py2.7.egg/deluge/core/daemon.py", line 144, in start
    reactor.run()
  File "/usr/lib/python2.7/dist-packages/twisted/internet/base.py", line 1194, in run
    self.mainLoop()
  File "/usr/lib/python2.7/dist-packages/twisted/internet/base.py", line 1203, in mainLoop
    self.runUntilCurrent()
--- <exception caught here> ---
  File "/usr/lib/python2.7/dist-packages/twisted/internet/base.py", line 825, in runUntilCurrent
    call.func(*call.args, **call.kw)
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0.dev603-py2.7.egg/deluge/core/torrentmanager.py", line 408, in on_add_torrent_alert
    d, options, state, filename, magnet, resume_data, filedump, save_state = self.torrents_loading.pop(torrent_id)
exceptions.KeyError: 'd65db24766e6cf2244a7d35af524ecff66617b75'

23:09:38.234 [ERROR   ][deluge.ui.client                       :157 ] RPCError Message Received!
--------------------------------------------------------------------------------
RPCRequest: core.add_torrent_magnet(magnet:?xt=urn:btih:D65DB24766E6CF2244A7D35AF524ECFF66617B75&amp;tr=udp%3A%2F%2Ftracker.openbittorrent.com%3A80&amp;tr=udp%3A%2F%2Ftracker.publicbt.com%3A80&amp;tr=udp%3A%2F%2Ftracker.ccc.de%3A80, {'add_paused': False, 'max_download_speed': -1.0, 'move_completed_path': '/media/truecrypt1/download/completi/vari', 'download_location': '/media/truecrypt1/download/Incomplete', 'seed_mode': False, 'max_upload_speed': -1.0, 'prioritize_first_last_pieces': False, 'max_upload_slots': -1, 'move_completed': True, 'pre_allocate_storage': False, 'sequential_download': False, 'max_connections': -1})
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0.dev603-py2.7.egg/deluge/core/rpcserver.py", line 293, in dispatch
    ret = self.factory.methods[method](*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0.dev603-py2.7.egg/deluge/core/core.py", line 319, in add_torrent_magnet
    return self.torrentmanager.add(magnet=uri, options=options)
  File "/usr/local/lib/python2.7/dist-packages/deluge-2.0.0.dev603-py2.7.egg/deluge/core/torrentmanager.py", line 340, in add
    raise AddTorrentError("Torrent already being added (%s)." % torrent_id)
AddTorrentError: Torrent already being added (D65DB24766E6CF2244A7D35AF524ECFF66617B75).

AddTorrentError: Torrent already being added (D65DB24766E6CF2244A7D35AF524ECFF66617B75).
--------------------------------------------------------------------------------
Unhandled error in Deferred:
23:09:38.235 [CRITICAL][twisted                                :154 ] Unhandled error in Deferred:


Traceback (most recent call last):
Failure: deluge.error.AddTorrentError: Torrent already being added (D65DB24766E6CF2244A7D35AF524ECFF66617B75).
23:09:38.235 [CRITICAL][twisted                                :154 ] 
/usr/local/lib/python2.7/dist-packages/deluge-2.0.0.dev603-py2.7.egg/deluge/ui/gtkui/listview.py:432: GtkWarning: IA__gtk_tree_view_remove_column: assertion 'column->tree_view == GTK_WIDGET (tree_view)' failed
  self.treeview.remove_column(self.columns[header].column)

While seeding/downloading a large number of torrents (~200, but issue starts appearing with much fewer torrents), upload and download speed drops to 0 every time Deluge is generating resume data, which happens every 3-4 minutes. After resume data for all torrents is generated, speed picks back up slowly as it looks like it has to reconnect to all peers, only to happen again a few minutes later.

The logs contain the following data for every torrent file:

[DEBUG   ] 20:35:42 alertmanager:123 save_resume_data_alert: torrent_name1 resume data generated
[DEBUG   ] 20:35:42 alertmanager:123 save_resume_data_alert: torrent_name2 resume data generated
[DEBUG   ] 20:35:42 alertmanager:123 save_resume_data_alert: torrent_name3 resume data generated
[DEBUG   ] 20:35:42 torrentmanager:1106 on_alert_save_resume_data
[DEBUG   ] 20:35:42 torrentmanager:1106 on_alert_save_resume_data
[DEBUG   ] 20:35:42 torrentmanager:1106 on_alert_save_resume_data

And it goes on like this for all torrents which takes ~10 seconds, then transfer speeds start going back up.

Here is an example speed graph (5 sec update frequency):