Custom Query (2449 matches)

Hi,

I've found (and fixed) a temporary file race condition in the use of httpdownloader.py:download_file from the core/core.py:add_torrent_url method in Deluge 1.3.x.

By default, download_file will not use the temporary file name supplied by add_torrent_url - it will use the filename suggested by the given URL. When using two Deluge processes started at the same time on the same torrent, this leads to an IO error at random as download_file (depending on ordering) clobbers or removes the downloaded torrent file with the same name that the other process is also attempting to download simultaneously.

(This can be seen in particular using add_torrent_url with an Ubuntu ISO torrent - ​http://torrent.ubuntu.com:6969/file?info_hash=%60%D5%D8%23%28%B4Tu%11%FD%EA%C9%BFM%01%12%DA%A0%CE%00)

The supplied patch fixes this by making add_torrent_url call download_file with the force_filename option set to True, forcing download_file to always use the unique mkstemp-generated filename supplied from add_torrent_url.

Kind regards,

Geoff Kassel.

Originally reported at:

​https://bugs.launchpad.net/bugs/708726

Patch here:

​https://bugs.launchpad.net/ubuntu/+source/deluge/+bug/708726/+attachment/1824072/+files/708726.udiff

Binary package hint: deluge

ProblemType: Crash DistroRelease: Ubuntu 11.04 Package: deluge-gtk 1.3.1-1 ProcVersionSignature: Ubuntu 2.6.37-12.26-generic-pae 2.6.37 Uname: Linux 2.6.37-12-generic-pae i686 NonfreeKernelModules: nvidia Architecture: i386 Date: Thu Jan 27 21:11:11 2011 ExecutablePath: /usr/bin/deluge-gtk InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release i386 (20100429) InterpreterPath: /usr/bin/python2.7 PackageArchitecture: all ProcCmdline: /usr/bin/python /usr/bin/deluge-gtk ProcEnviron:

LANGUAGE=en LANG=ru_RU.UTF-8 LC_MESSAGES=en_AG.utf8 SHELL=/bin/bash

PythonArgs: usr/bin/deluge-gtk SourcePackage: deluge Title: deluge-gtk crashed with TypeError in cell_data_queue(): could not convert argument to correct param type Traceback:

Traceback (most recent call last):

File "/usr/lib/pymodules/python2.7/deluge/ui/gtkui/torrentview.py", line 131, in cell_data_queue

cell.set_property("text", value + 1)

TypeError: could not convert argument to correct param type

UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare

architecture: x86_64 cmdline: /usr/bin/python /usr/bin/deluge-gtk component: deluge executable: /usr/bin/deluge-gtk kernel: 2.6.35.10-74.fc14.x86_64 reason: createtorrentdialog.py:294:_on_button_save_clicked:IndexError: list index out of range release: Fedora release 14 (Laughlin) time: 1296760033 uid: 500

backtrace

createtorrentdialog.py:294:_on_button_save_clicked:IndexError: list index out of range

Traceback (most recent call last):

File "/usr/lib/python2.7/site-packages/deluge-1.3.900_dev-py2.7.egg/deluge/ui/gtkui/createtorrentdialog.py", line 294, in _on_button_save_clicked

trackers[tier].append(tracker)

IndexError: list index out of range

Local variables in innermost frame: widget: <gtk.Button object at 0x34de9b0 (GtkButton at 0x3668550)> trackers: [[]] file_filter: <gtk.FileFilter object at 0x34de230 (GtkFileFilter at 0x3676380)> self: <deluge.ui.gtkui.createtorrentdialog.CreateTorrentDialog instance at 0x34e0950> chooser: <gtk.FileChooserDialog object at 0x34defa0 (GtkFileChooserDialog at 0x326d760)> is_remote: False tracker: '​http://tracker.openbittorrent.com/announce' result: '/home/shnurapet/gnome3_test_20110203.torrent' tier: 1 path: '/mnt/HD2/gnome3_test_20110203' response: -5

reproduce

1. Create a torrent

2. 3.