Custom Query (2449 matches)

For portability, please use errno constants instead of integer values. Patch attached, but please double-check because may require some "import errno".

Hi,

When looking at the source code I saw that DaemonSSLProxy.init have a mutable default parameter value: ​http://git.deluge-torrent.org/deluge/tree/deluge/ui/client.py#n269

This may be the source of bugs as explained here:

​http://effbot.org/zone/default-values.htm#valid-uses-for-mutable-defaults

It may be intentional, but I am not sure as I am not familiar with the code. If it is intentional, a comment should be added to say so. Otherwise, the method should be changed to look like this:

    def __init__(self, event_handlers=None):
        if event_handlers is None:
            event_handlers = {}

The curses call to stdscr.clear() redraws the whole window on every update which causes screen flickering. By replacing the call with one to stdscr.erase() the updates are smooth.

I did not notice a negative impact but did not grasp the whole difference between clear vs. erase either.