Custom Query (2449 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (703 - 705 of 2449)

Ticket Resolution Summary Owner Reporter
#1968 Fixed OSError if deluged not installed and attempted start from connection manager Calum Calum
Description

Start in non-classic and try to start daemon from connection manager. The correct warning appears in gtkui but error is not handled properly.

[ERROR   ] 18:14:58 client:584 [Errno 2] No such file or directory
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/deluge/ui/client.py", line 582, in start_daemon
    subprocess.call(["deluged", "--port=%s" % port, "--config=%s" % config])
  File "/usr/lib/python2.7/subprocess.py", line 493, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib/python2.7/subprocess.py", line 679, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1239, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
#1971 Fixed Unify Options Handling Calum jumentous
Description

Currently each startup script handles its own options processing, and the 6 or so standard options code (-l -L -c -q -r) is c&p into each.

This results for example in differences between option handling such as regarding config file loading in ui.py and main.py:start_ui not to mention it is just bad form.

This patch subclasses OptionParser and handles the default options in a central place. It is mostly just moving code around.

There are possibly better ways to handle this, maybe create a class of StartupTarget of which StartUI, StartDaemon and _UI are subclasses of and handle options there, but this way has the smallest affect on the existing code.

#1972 Fixed Useless ui.UI class Calum jumentous
Description

Whilst it would appear that the ui.py:UI class used to be intended for something it is only used in 2 places:

  1. from start_ui where it is called to choose which UI to launch. However at no point here does it use self so in essence this could/should just be a function.
  1. as a base class for deluge/ui/web/web.py:Web, however the init of this class does not chain to the parent class or do anything similar.

I can only imagine that this cross over came from old, removed code and is no longer needed.

This code can simply be merged back into start_ui, if for no other reason that it's less confusing for people reading the code and distinguishing the difference between the _UI and UI classes.

Batch Modify
Note: See TracBatchModify for help on using batch modify.
Note: See TracQuery for help on using queries.