Custom Query (2448 matches)

if you access deluge web UI with a reverse proxy header it crashes

web.Server Traceback (most recent call last):
builtins.TypeError: must be str, not bytes
/usr/lib/python3/dist-packages/twisted/web/server.py:190 in process
189        try:
190            resrc = self.site.getResourceFor(self)
191            if resource._IEncodingResource.providedBy(resrc):
/usr/lib/python3/dist-packages/twisted/web/server.py:826 in getResourceFor
825        request.sitepath = copy.copy(request.prepath)
826        return resource.getChildForRequest(self.resource, request)
827
/usr/lib/python3/dist-packages/twisted/web/resource.py:98 in getChildForRequest
97        request.prepath.append(pathElement)
98        resource = resource.getChildWithDefault(pathElement, request)
99    return resource
/usr/lib/python3/dist-packages/deluge/ui/web/server.py:580 in getChildWithDefault
579        if base[0] != '/':
580            base = '/' + base
581
builtins.TypeError: must be str, not bytes

the base variable type is bytes from the header and not a string which blows up.

When you retrieve the header contents here: ​https://github.com/deluge-torrent/deluge/blob/develop/deluge/ui/web/server.py#L572

its returning bytes and not str. Bytes are what's what's specified in the twisted docs: ​https://twistedmatrix.com/documents/current/api/twisted.web.http.Request.html#getHeader

so it might be fixable with casting those bytes to a string or concatenating them another way.

This bug is new as of 2.x.x which makes sense since it looks like webui was refactored some.

I am trying to run deluged 2.0.0 with Python 2.7.15, and it logs the errors below.

Do deluged and deluge-web 2.0.0 run with Python 2.7, or is Python 3.5 required?

I found ​this to add SimpleNamespace? to Python 2.7, just in case.

Unhandled error in Deferred:
[CRITICAL][twisted                       :154 ] Unhandled error in Deferred:
Traceback (most recent call last):
  File ".../deluge-2.0.0-py2.7.egg/deluge/component.py", line 126, in on_start
  File ".../deluge-2.0.0-py2.7.egg/deluge/component.py", line 120, in _component_start_timer
  File ".../Twisted-19.2.1-py2.7-linux-x86_64.egg/twisted/internet/task.py", line 194, in start
  File ".../Twisted-19.2.1-py2.7-linux-x86_64.egg/twisted/internet/task.py", line 239, in __call__
--- <exception caught here> ---
  File ".../Twisted-19.2.1-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 151, in maybeDeferred
  File ".../deluge-2.0.0-py2.7.egg/deluge/core/alertmanager.py", line 62, in update
  File ".../deluge-2.0.0-py2.7.egg/deluge/core/alertmanager.py", line 129, in handle_alerts
exceptions.AttributeError: 'module' object has no attribute 'SimpleNamespace'
[CRITICAL][deluge.log                    :205 ] twisted.internet.defer 

On py3 install(arch fully updated), then I cannot remove a torrent from the list, and have to use CLI mode instead. No error shown, but nothing happens when selecting to remove, with or without keeping file(s). The error-log from the console-UI is named 'remove-torrent.log'.

Last, when having a torrent with a file that's not downloaded yet, like when using ipmagnet to test what IP is published to tracker, and then pressing right-arrow, then errors are repeatedly splashed all over the screen. This error is months old I remember btw. The error-log from console-UI is named 'empty-rightarrow.log'.

Thanks in advance!