Custom Query (2447 matches)

i can't seem to change my webui password. The logs say

Error calling method `auth.change_password`: Unicode-objects must be encoded before hashing

After setting base path, I getting this error:

01:37:40 [CRITICAL][twisted                    :154 ] Unhandled Error
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/twisted/protocols/basic.py", line 571, in dataReceived
    why = self.lineReceived(line)
  File "/usr/lib/python3/dist-packages/twisted/web/http.py", line 2013, in lineReceived
    self.allContentReceived()
  File "/usr/lib/python3/dist-packages/twisted/web/http.py", line 2104, in allContentReceived
    req.requestReceived(command, path, version)
  File "/usr/lib/python3/dist-packages/twisted/web/http.py", line 866, in requestReceived
    self.process()
--- <exception caught here> ---
  File "/usr/lib/python3/dist-packages/twisted/web/server.py", line 190, in process
    resrc = self.site.getResourceFor(self)
  File "/usr/lib/python3/dist-packages/twisted/web/server.py", line 826, in getResourceFor
    return resource.getChildForRequest(self.resource, request)
  File "/usr/lib/python3/dist-packages/twisted/web/resource.py", line 98, in getChildForRequest
    resource = resource.getChildWithDefault(pathElement, request)
  File "/usr/lib/python3/dist-packages/deluge/ui/web/server.py", line 585, in getChildWithDefault
    request.base = base.encode('idna')
builtins.UnicodeError: encoding with 'idna' codec failed (UnicodeError: label too long)

if you access deluge web UI with a reverse proxy header it crashes

web.Server Traceback (most recent call last):
builtins.TypeError: must be str, not bytes
/usr/lib/python3/dist-packages/twisted/web/server.py:190 in process
189        try:
190            resrc = self.site.getResourceFor(self)
191            if resource._IEncodingResource.providedBy(resrc):
/usr/lib/python3/dist-packages/twisted/web/server.py:826 in getResourceFor
825        request.sitepath = copy.copy(request.prepath)
826        return resource.getChildForRequest(self.resource, request)
827
/usr/lib/python3/dist-packages/twisted/web/resource.py:98 in getChildForRequest
97        request.prepath.append(pathElement)
98        resource = resource.getChildWithDefault(pathElement, request)
99    return resource
/usr/lib/python3/dist-packages/deluge/ui/web/server.py:580 in getChildWithDefault
579        if base[0] != '/':
580            base = '/' + base
581
builtins.TypeError: must be str, not bytes

the base variable type is bytes from the header and not a string which blows up.

When you retrieve the header contents here: ​https://github.com/deluge-torrent/deluge/blob/develop/deluge/ui/web/server.py#L572

its returning bytes and not str. Bytes are what's what's specified in the twisted docs: ​https://twistedmatrix.com/documents/current/api/twisted.web.http.Request.html#getHeader

so it might be fixable with casting those bytes to a string or concatenating them another way.

This bug is new as of 2.x.x which makes sense since it looks like webui was refactored some.