Custom Query (2425 matches)

Like #1234 but for the WebUI.

Deluge 0.6.0.0r3270

adding a new torrent fails with:

[DEBUG   ] 17:54:05 client:204 Attempting to add torrent files: ['/mnt/series/temp/b174.torrent']
[WARNING ] 17:54:05 client:100 Could not contact daemon: <Fault 1: "exceptions.AttributeError:Torrent instance has no attribute 'stop_ratio'">
[INFO    ] 17:54:05 client:110 Setting core uri as None
[DEBUG   ] 17:54:05 component:137 Stopping component SystemTray..
[DEBUG   ] 17:54:05 component:137 Stopping component PluginManager..
[DEBUG   ] 17:54:05 component:137 Stopping component Preferences..
[DEBUG   ] 17:54:05 component:137 Stopping component DbusInterface..
[DEBUG   ] 17:54:05 component:137 Stopping component StatusBar..
[DEBUG   ] 17:54:05 component:137 Stopping component AddTorrentDialog..
[DEBUG   ] 17:54:05 component:137 Stopping component ConnectionManager..
[DEBUG   ] 17:54:05 component:137 Stopping component TorrentView..
[DEBUG   ] 17:54:05 component:137 Stopping component Signals..
[DEBUG   ] 17:54:05 signalreceiver:72 Unable to deregister client from server: 'The core proxy is invalid.'
[DEBUG   ] 17:54:05 signalreceiver:74 Shutting down signalreceiver
[DEBUG   ] 17:54:05 signalreceiver:77 Joining listening thread..
[DEBUG   ] 17:54:05 component:137 Stopping component TorrentDetails..
[DEBUG   ] 17:54:05 configmanager:88 Getting config 'gtkui.conf'
[DEBUG   ] 17:54:05 files_tab:201 Saving FilesTab state file: files_tab.state
[DEBUG   ] 17:54:05 configmanager:88 Getting config 'gtkui.conf'
[DEBUG   ] 17:54:05 peers_tab:161 Saving FilesTab state file: peers_tab.state
[DEBUG   ] 17:54:05 configmanager:88 Getting config 'gtkui.conf'
[DEBUG   ] 17:54:05 torrentdetails:289 Saving TorrentDetails state file: tabs.state
[DEBUG   ] 17:54:05 component:137 Stopping component CoreConfig..
[DEBUG   ] 17:54:05 component:137 Stopping component SideBar..
[DEBUG   ] 17:54:05 component:137 Stopping component QueuedTorrents..
[DEBUG   ] 17:54:05 component:137 Stopping component MainWindow..
[DEBUG   ] 17:54:05 component:137 Stopping component ToolBar..
[DEBUG   ] 17:54:05 component:137 Stopping component MenuBar..

this is with a clean config

Setup.

• Multi-monitor setup - 3 monitors
• WM - i3
• Firefox on 1st workspace of 1 screen
• Deluge-gtk 1.3.7 on 6th workspace of 2 screen.
• Firefox has been configured to use Deluge-gtk for magnet links.

Tests

• With deluge-gtk being on the active, visible first workspace on the second monitor. Clicking on Add Torrent button the "Add Torrent" dialog appears.
• With deluge-gtk being on the inactive, visible first workspace on the second monitor. Clicking on magnet links in the Firefox on the first screen works. Deluge becomes active and the "Add Torrent" dialog appears.
• With deluge-gtk being on the inactive, visible second workspace on the second monitor. Clicking on magnet links in the Firefox on the first screen does not work, no "Add Torrent" dialog appears. The workspace icon flashes to show that deluge-gtk has activated but the workspace isn't automatically switched to and on manually switching to it there is no dialog present.

Trackback

  File "/usr/lib/python2.7/site-packages/twisted/protocols/policies.py", line 120, in dataReceived
    self.wrappedProtocol.dataReceived(data)
  File "/usr/lib/python2.7/site-packages/deluge/ui/client.py", line 179, in dataReceived
    d.callback(request[2])
  File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 382, in callback
    self._startRunCallbacks(result)
  File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 490, in _startRunCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 577, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/usr/lib/python2.7/site-packages/deluge/ui/gtkui/addtorrentdialog.py", line 199, in _on_config_values
    self._show(focus)
  File "/usr/lib/python2.7/site-packages/deluge/ui/gtkui/addtorrentdialog.py", line 172, in _show
    if component.get("MainWindow").is_on_active_workspace():
  File "/usr/lib/python2.7/site-packages/deluge/ui/gtkui/mainwindow.py", line 315, in is_on_active_workspace
    return win.is_on_workspace(win.get_screen().get_active_workspace())
exceptions.TypeError: Wnck.Window.is_on_workspace() argument 1 must be wnck.Workspace, not None

Appears to be an assuming that a screen always has an active workspace, which in the case of multiple monitors might not always be true.

I changed check at the end of mainwindow.py to be

if win.get_screen().get_active_workspace() is not None:
    return win.is_on_workspace(win.get_screen().get_active_workspace())
else:
    return False

which fixes the issue.

Not entirely sure of the required behaviour here, perhaps deluge-gtk should be activating the workspace on that monitor, but WnckScreen? doesn't appear to have a set_active_workspace function or anything approaching that.