Custom Query (2449 matches)

As title, currently it's not possible to add new host in console-UI as states port need be integer.

I added some debug-prints and found the 'result' dict indeed saves port as string, e.g. I tested it worked here just changing line 107 of connectionmanager.py from/to:

                result['port']['value'],

                int(result['port']['value']),

Also, currently when having input new host data and pressed return then need also press escape to get out of connection-manager, which i just changed in same file line 135 from/to:

            self.update_select_host_popup()

            self.pop_popup()

Thanks in advance.

As title, optional trackers defined in magnet URI's with '&tr=' args, isn't applied e.g. in GTK-UI when pressing 'add' without metadata-prefetching finished yet / filelist empty. If in GTK-UI waiting until prefetching finished / file(s) listed, then does work however. Same issue when adding magnets with optional trackers through 'deluge-console add' command.

It's irrelevant which libtorrent version used, but happens in deluge 2.1.0 but not 2.0.5 and down. I narrowed it further down specifically to commit 2bd095e being the culprit: ​https://github.com/deluge-torrent/deluge/commit/2bd095e5bfc49cbe178fc0ba9df38b88afc238aa

Issue originally found and reported by nemonein in following forum-thread: ​https://forum.deluge-torrent.org/viewtopic.php?f=7&p=235005#p235005

Thanks alot in advance!

Sending a request with 'Content-Type: application/json' works fine:

$ curl 'http://127.0.0.1:8112/json' -X POST \
       -H 'Content-Type: application/json' \
       --data-raw '{"method":"daemon.get_version","params":[],"id":1}'
{ "result": null
, "error": { "message": "Not authenticated"
           , "code": 1
           }
, "id": 1}

But it should work too with 'Content-Type: application/json;charset=utf-8' although it doesn't:

$ curl 'http://127.0.0.1:8112/json' -X POST \
       -H 'Content-Type: application/json;charset=utf-8' \
       --data-raw '{"method":"daemon.get_version","params":[],"id":1}'
{ "result": null
, "id": null
, "error": { "code": 5
           , "message": "JSONException: Invalid JSON request content-type: application/json;charset=utf-8"
           }
}

This is a valid content-type as per https://greenbytes.de/tech/webdav/rfc2616.html#header.content-type
I believe I know how to fix this and will create a PR for it.