Custom Query (2449 matches)

When I upload a plugin into deluge 1.2.3 trough webui, it saves the plugin as shown in upload selector, ie "C:\fakepath\XMPPNotify-0.1_dev-py2.6.egg" instead of just "XMPPNotify-0.1_dev-py2.6.egg" in plugins directory... Also log says that "[WARNING ] 05:24:26 pluginmanagerbase:122 Cannot enable non-existant plugin C fakepath XMPPNotify "

Here is ls command after uploaded plugin with webui and then working plugin uploaded trough deluge-gtk (using RPC):

root@lara:/var/lib/deluge/plugins# ls -l

total 48

-rw-rw-rw- 1 deluge deluge 20932 2010-05-05 05:24 C:\fakepath\XMPPNotify-0.1_dev-py2.6.egg

-rw-rw-rw- 1 deluge deluge 20932 2010-05-05 05:27 XMPPNotify-0.1_dev-py2.6.egg

There is a bug in core.py that increases the amount of uploaded data (and thereby the share ratio) when a torrent is paused or the order in the queue is changed (it does not appear however when the method of sorting is changed).

To reproduce:

Take a torrent having uploaded a fair amount of data during this session (preferably at least 10% of the total uploaded amount, that way it is more visible). When this torrent is paused or its queue order is changed (by moving it either up or down by one place or by queuing it to the top/bottom), the amount of uploaded data will increase by the amount already uploaded during this session. Also, when you change the queue order, every torrent that also changes queue order by this act will undergo the same increase.

Cause:

In core.py, the function pickle_state, which is supposed to write the statistics of the torrent in a file in case of a crash or upon closing, saves the amount of uploaded data to torrent.uploaded_memory. The problem is that this function is also called when changing queue order (by the functions queue_top, queue_up, queue_down and queue_bottom) and upon pausing (by set_user_pause), so that any of these actions transforms the amount U of uploaded data into U+x where x is the amount of data uploaded during the current session, so that after n of the actions, your uploaded data amounts to U+n*x; the solution is to either disable pickle_state in these cases (what I have done on my own client as a quick fix, I do not mind the higher vulnerability against crashed that much if it keeps my ratio safe) or to modify the function so as to only save to an external variable that will be restored upon starting Deluge.

Also, so far I have only seen reports of this problem on systems running linux (Ubuntu 8.04 to be more precise, see ​http://groups.google.com/group/deluge-dev/browse_thread/thread/5f685bd41fddddc9/e7aa6dd7e03556d5?lnk=gst&q=ratio+5.8.9#e7aa6dd7e03556d5 and ​https://bugs.launchpad.net/ubuntu/+source/deluge-torrent/+bug/222478), but I suppose that this could also happen under other operating systems (I did not test this though, so I might be wrong).

whenever one of the nightly packages is upgraded and the deluged daemon is restarted, the torrent queue is empty again.