Custom Query (2449 matches)

In my own plugin I create a server using reactor.listenTCP and in the disable function, I run "stopListening" to clean up.

When the plugin is loaded and I shut down Deluge, I get the "dictionary changed size during iteration" exception. The problem stems from this line: ​https://github.com/deluge-torrent/deluge/blob/develop/deluge/component.py#L451

If I change self.components.values() to list(self.components.values()) it all goes away.

Deluge-gtk 2.0.3 has a keyboard shortcut for Quit & Shutdown daemon (Shift+Ctrl+Q), but no shortcut for Quit.

This patch adds a keyboard shortcut for Quit (Ctrl+Q):

--- ui/gtk3/glade/main_window.ui.orig	2019-11-03 14:01:29.250274885 +0100
+++ ui/gtk3/glade/main_window.ui	2019-11-03 14:01:44.642187366 +0100
@@ -174,6 +174,7 @@
                         <property name="use_stock">False</property>
                         <property name="accel_group">accelgroup1</property>
                         <signal name="activate" handler="on_menuitem_quit_activate" swapped="no"/>
+                        <accelerator key="Q" signal="activate" modifiers="GDK_CONTROL_MASK"/>
                       </object>
                     </child>
                   </object>

When trying to remove non downloading torrents, no matter how added (via file or magnet). I get this error on console:

16:51:03 [ERROR   ][deluge.ui.client                  :169 ] RPCError Message Received!
--------------------------------------------------------------------------------
RPCRequest: core.remove_torrents(['2939a4c2c56580d03b0f9e46b77954d8db045bb1', '41316922455745a997a0e6b7359d0193be3600e0', '5eeaa9881ea8c71240db4465ae90a92d75e39d50', '2804f14263e17255f6a3028c2dada6e61deee2d9'], True)
--------------------------------------------------------------------------------
TypeError
join() argument must be str or bytes, not 'NoneType': Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/deluge/core/rpcserver.py", line 347, in on_fail
    failure.raiseException()
  File "/usr/lib/python3/dist-packages/twisted/python/failure.py", line 385, in raiseException
    raise self.value.with_traceback(self.tb)
  File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", line 653, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/usr/lib/python3/dist-packages/twisted/internet/task.py", line 865, in <lambda>
    d.addCallback(lambda ignored: callable(*args, **kw))
  File "/usr/lib/python3/dist-packages/deluge/core/core.py", line 613, in do_remove_torrents
    torrent_id, remove_data=remove_data, save_state=False
  File "/usr/lib/python3/dist-packages/deluge/core/torrentmanager.py", line 745, in remove
    torrent.delete_torrentfile(delete_copies)
  File "/usr/lib/python3/dist-packages/deluge/core/torrent.py", line 1317, in delete_torrentfile
    os.path.join(self.config['torrentfiles_location'], self.filename)
  File "/usr/lib/python3.6/posixpath.py", line 94, in join
    genericpath._check_arg_types('join', a, *p)
  File "/usr/lib/python3.6/genericpath.py", line 149, in _check_arg_types
    (funcname, s.__class__.__name__)) from None
TypeError: join() argument must be str or bytes, not 'NoneType'

--------------------------------------------------------------------------------
Unhandled error in Deferred:
16:51:03 [CRITICAL][twisted                           :154 ] Unhandled error in Deferred:

16:51:03 [CRITICAL][deluge.log                        :93  ] twisted.internet.defer 
[Failure instance: Traceback (failure with no frames): <class 'deluge.error.WrappedException'>: join() argument must be str or bytes, not 'NoneType'
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/deluge/core/rpcserver.py", line 347, in on_fail
    failure.raiseException()
  File "/usr/lib/python3/dist-packages/twisted/python/failure.py", line 385, in raiseException
    raise self.value.with_traceback(self.tb)
  File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", line 653, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/usr/lib/python3/dist-packages/twisted/internet/task.py", line 865, in <lambda>
    d.addCallback(lambda ignored: callable(*args, **kw))
  File "/usr/lib/python3/dist-packages/deluge/core/core.py", line 613, in do_remove_torrents
    torrent_id, remove_data=remove_data, save_state=False
  File "/usr/lib/python3/dist-packages/deluge/core/torrentmanager.py", line 745, in remove
    torrent.delete_torrentfile(delete_copies)
  File "/usr/lib/python3/dist-packages/deluge/core/torrent.py", line 1317, in delete_torrentfile
    os.path.join(self.config['torrentfiles_location'], self.filename)
  File "/usr/lib/python3.6/posixpath.py", line 94, in join
    genericpath._check_arg_types('join', a, *p)
  File "/usr/lib/python3.6/genericpath.py", line 149, in _check_arg_types
    (funcname, s.__class__.__name__)) from None
TypeError: join() argument must be str or bytes, not 'NoneType'

]

On Ubuntu 18.04

deluge-common  --> 2.0.3-2~201906121747~ubuntu18.04.1 -- Deluge Common Files
deluge-console --> 2.0.3-2~201906121747~ubuntu18.04.1 -- Deluge Console UI
deluge-gtk     --> 2.0.3-2~201906121747~ubuntu18.04.1 -- Deluge GTK UI
deluge-web     --> 2.0.3-2~201906121747~ubuntu18.04.1 -- Deluge Web UI
deluged        --> 2.0.3-2~201906121747~ubuntu18.04.1 -- Deluge Daemon (deluged)

With stable ppa

deb http://ppa.launchpad.net/deluge-team/stable/ubuntu bionic main