Opened 15 years ago
Closed 15 years ago
#1009 closed bug (Fixed)
Enabling a plugin adds two items of the same name to the "Categories" view
Reported by: | squisher | Owned by: | andar |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | Unknown | Version: | 1.2.0_dev |
Keywords: | Cc: |
Description
Using rev. 5707, when I enable a plugin it gets added twice to the categories column on the left. When I disable it, one copy gets removed, but the second one stays.
Attachments (1)
Change History (6)
comment:1 by , 15 years ago
comment:2 by , 15 years ago
Ah, no email notification on updates of bugs... :-\
Anyway, it happens with all plugins. I looked around in the sources, and found a fix. The gtkui currently calls both "client.core.enable_plugin(name)" and "component.get("PluginManager").enable_plugin(name)". It seems that only the former is required, although I'm obviously not sure - this whole RPC thing makes understanding what happens not very easy :-).
by , 15 years ago
Attachment: | deluge-enable-plugins.diff added |
---|
Patch which only calls client.core and not the PluginManager when enabling/disabling plugins
comment:3 by , 15 years ago
I think this may have to do with my recent change to add a PluginEnabledEvent. When you enabled it on the Core, then the gtkui receives the event and enables it on it's side.. So it may be doing it twice..
comment:4 by , 15 years ago
That would have been my guess. The PluginEnabledEvent seems much cleaner! Then my patch should in fact be the correct fix.
Is it a specific plugin? What plugins are you enabling?