Opened 11 years ago

Closed 8 years ago

Last modified 4 years ago

#1103 closed bug (Fixed)

Global "Stop seed at ratio" setting overrides per-torrent disabling of "Stop seed" setting

Reported by: man_in_shack Owned by:
Priority: minor Milestone: 2.x
Component: Core Version: 1.3.0
Keywords: Cc:

Description

In the per-torrent Options tag, there is a checkbox next to "Stop seed at ratio". It appears that this is autopopulated with the global values for this setting, but when un-checking the checkbox, the torrent is still stopped if the seed ratio is higher than the global setting.

Workaround: Set the per-torrent "Stop seed at ratio" setting to something ridiculously high (e.g. 10000) and hope you never reach it.

Suggested fix: The global "Stop seed at ratio" setting should be used for a default value for when the per-torrent setting has not been modified. If the global setting changes, any torrents that have settings that match the old global setting should have their settings changed to match. Apart from this, there should be no functionality directly associated with the global "Stop seed at ratio" setting.

Change History (6)

comment:1 Changed 11 years ago by andar

  • Milestone set to 1.3.0

This has been partially fixed in [6037].. There needs to be some bigger changes to really make this work properly. Perhaps adding a "Ignore Global Queue Settings" option would work, or like you said, simply modifying all the torrent's stop at share settings when the global is modified.

comment:2 Changed 11 years ago by andar

  • Milestone changed from 1.3.0 to Future

comment:3 Changed 10 years ago by Cas

  • Component changed from other to core
  • Version changed from 1.2.0_rc4 to 1.3.0

comment:4 Changed 8 years ago by Cas

  • Milestone changed from Future to 1.4.0

comment:5 Changed 8 years ago by gazpachoking

  • Resolution set to fixed
  • Status changed from new to closed

This was fixed quite a while ago. f8d7f22167

comment:6 Changed 4 years ago by Cas

  • Milestone changed from 2.0.x to 2.x

Milestone renamed

Note: See TracTickets for help on using tickets.