#1109 closed bug (Fixed)
watch dir with special characters
| Reported by: | MartinEve | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | Core | Version: | 1.3.6 |
| Keywords: | watchdir autoadd | Cc: |
Description
Deluge RC5 seems to halt the watch-dir functionality whenever a torrent with Russian/Hebrew/non-standard-ascii character filenames are added to the watch directory.
For example:
рвшевсго.torrent
stops the watch directory from picking up any subsequently added torrents. After this I have to delete all from the watch dir and restart the client for any changes to take effect.
Attachments (1)
Change History (15)
comment:1 by , 15 years ago
| Status: | new → pending |
|---|
comment:2 by , 15 years ago
| Status: | pending → new |
|---|
I will try the logging tonight and report back. However, I have also noticed that I get the same effect for filenames containing htmlentities: ie. &
comment:3 by , 15 years ago
| Version: | 1.2.0_rc5 → 1.2.1 |
|---|
If i have a torrent file named Annika Aakj�r - Missionær - 2010 (CD - MP3 - 224).torrent and I try to add it, it fails, but if i rename it to Annika Aakjr - Missionær - 2010 (CD - MP3 - 224).torrent it works correctly. If this file is put into a watch directory, it breaks the deluge watch function, and won't work properly again until the client is restarted.
comment:4 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I've fixed this by ignoring the torrent in this case. It seems that this happens when the filename is not in a proper encoding for the filesystem or locale.
comment:5 by , 11 years ago
| Keywords: | watchdir autoadd added |
|---|---|
| Resolution: | Fixed |
| Status: | closed → reopened |
| Summary: | RC5 watch dir with special characters → watch dir with special characters |
| Version: | 1.2.1 → 1.3.6 |
I am not satisfied with the patch and I ask that torrents are not just ignored. (should I mark as a feature-request?)
by , 10 years ago
| Attachment: | 0001-1109-Load-torrents-with-special-characters-in-autoad.patch added |
|---|
comment:6 by , 10 years ago
| Resolution: | → Fixed |
|---|---|
| Status: | reopened → closed |
I found the problem is autoadd.py try to join unicode string (autoadd directory path) with byte string(torrent filename), change autoadd directory path into byte string should fix this bug
comment:7 by , 10 years ago
| Resolution: | Fixed |
|---|---|
| Status: | closed → reopened |
comment:8 by , 10 years ago
| Component: | other/unknown → Plugin |
|---|---|
| Milestone: | → 1.4.0 |
comment:10 by , 10 years ago
| Milestone: | 1.4.0 → 2.0.0 |
|---|
comment:11 by , 9 years ago
| Component: | Plugin → Core |
|---|---|
| Milestone: | 2.0 → 1.3.x |
comment:12 by , 9 years ago
| Resolution: | → Fixed |
|---|---|
| Status: | reopened → closed |
I cannot see any issue in 1.3.12 and the patch supplied by lefthaha does not make sense as os.listdir returns the same type as provided. If you can provide an example torrent and your system setup then I can look into it further.
comment:13 by , 9 years ago
Confirm, it works fine in 1.3.12 without my patch
OS: Archlinux test with chinese and japanese characters in filename
No idea what happened in previous version :)
I just tried this by renaming a torrent file and copying it into the autoadd directory:
Worked just fine.
Perhaps there is an issue with the torrent file itself? Could you try reproducing this with debug logging?