Infinite login prompt in web ui through reverse proxy

[Vladimir Berezhnoy]

When I use web ui through nginx as reverse proxy, authentification never completes and keep showing the box with Login field. Also firefox gets hung on the page and consume 100% cpu. This doesn't hapen when connecting to web ui dirctly.

I'm using following nginx config:

location /deluge {

proxy_pass ​http://s:8112/; proxy_redirect off;

proxy_set_header Host $host; proxy_set_header X-Real-IP $remote_addr; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; proxy_set_header X-Deluge-Base /deluge/;

commit e7c7b8f4db4acaa5811c2573180a0afd6d24f947

[Damien Churchill]

This is an issue with your proxy setup. I haven't set up nginx before but in Apache you need to configure Cookie passing.

[Motiejus]

I needed reverse proxy with nginx as well, did not work for the same reason, and I had a deeper look. The problem was that deluge was not rewriting it's cookie paths correctly: _session_id=88ee05d3d56c35ba54a4dc64b7fd80cf2390; Expires=Fri, 04 Feb 2011 03:31:15 GMT; Path=/json

Should be: _session_id=88ee05d3d56c35ba54a4dc64b7fd80cf2390; Expires=Fri, 04 Feb 2011 03:31:15 GMT; Path=/deluge/json

There is a four-line patch to auth.py. It worked with nginx config as above, --base='/deluge/'.

[Motiejus]

auth.py cookie base path vs deluge-web 1.3.1

[Motiejus]

Actual nginx configuration that worked for me:

    location /deluge/ {
        proxy_pass  http://127.0.0.1:8112/;
        proxy_redirect  off;
        proxy_set_header  Host       $host;
        proxy_set_header  X-Real-IP  $remote_addr;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_pass_header Set-Cookie;
        proxy_pass_header P3P;
    }   

Note that with proxy_pass_header Set-Cookie; set it doesn't work without the patch for the same reason mentioned.

[Damien Churchill]

Thanks for this, I just assumed it was a web-server misconfiguration since it worked in apache, and I don't really use a reverse proxy so haven't had much time to investigate why it was happening.

I'll try and get around to applying this at some point today.

[Damien Churchill]

Applied in master rb0a0574ae0 and 1.3-stable r26410ca9c1

[Motiejus]

Good, thanks. One question. Will this line:

component.get("Web").get_config()["base"])

work with X-Deluge-Base header?

[Motiejus]

Tried. Did not work. FYI, My patch makes authentication work only for config entry:

$XDG_CONFIG_HOME/deluge/web.conf:
...
"base" : "/deluge/",
...

[Damien Churchill]

No that wouldn't work, the base can be switched dynamically per-request so I don't modify the config value.

I wonder if request.path is simple enough? Would you mind testing as I don't have a nginx reverse proxy set up at the moment.

[Motiejus]

Hum, I am not sure if request has it's real request path in reverse proxy configuration. Client request:

​http://server/deluge/ in reverse proxy (apache as well) becomes to ​http://127.0.0.1:8112/ consequently request.path is "/", am I right? This is why you needed base parameter, since server sitting behind proxy does not know anything about real path.

I will gladly test any configurations.

[Damien Churchill]

Very true, sorry I have only just woken up :-)

In that case I would suggest a get_base(request): ... function in common.py and that could then be shared between auth and server. That sounds the best to me.

[j2cx]

Hi. First, thanks for the patch! (and sorry in advance for my approximative english).

Using 1.3.1 with nginx proxy, I saw with this patch has as a side effect to get the file upload progress bar blocked into a loop while uploading a local file.

This is because the base's value isn't added to the FileWindow.js or deluge-all.js, with ngingx denying the access to /upload. The loop seems to be just a ui behavavior.

Got it to work adding deluge.config.base to the upload url in deluge-all.js, line 352.

As I didn't saw this modification appearing in the sources from git repo, this places seems to be the better to report it ;-)

[Damien Churchill]

Fixed by aef2a83f25d0d66a5678eef205f0580f1eb01ac7.