Deluge apply the queue preferences of label always

[simonbcn]

I explain this with images.
I have defined in Preferences > Queue:

And I have one label (series) with this queue preferences:

I add one torrent and this is its queue preferences:

It's correct.

But I change its label from none to series and this is its queue preferences now:

It's incorrect this behaviour.

[Calum]

Confirmed, the label does not respect "queue settings" is not selected and instead sets no seed ratio.

[Chase]

Label plugin is setting it's own defaults instead of leaving the global defaults alone. My proposed fix: ​http://github.com/gazpachoking/deluge/commit/0f7e2377662398a9e60fef47e320c386ae6b8aff

[simonbcn]

@gazpachoking thanks.
I have modified it and I've reinstalled deluge and it seems to work correctly.

[andar]

Fixed in master.

[simonbcn]

It's not solved. The problem persists with last git version (I updated yesterday).

[Chase]

I think you must have an old version of the plugin somewhere, because this problem is fixed in git master.

[simonbcn]

Torrent options with label1:

I change the torrent to label2:

The same error with queue values.

[Chase]

When you set the label from label1 to label2, the preferences from label1 will be removed, thus reverting the torrent back to global settings. If your global settings are -1 for all the bandwidth options, then everything is working as expected. If you need bandwidth settings for label2 to be something other than your global defaults, you will have to specify them in label2.

[simonbcn]

Replying to gazpachoking:

When you set the label from label1 to label2, the preferences from label1 will be removed, thus reverting the torrent back to global settings. If your global settings are -1 for all the bandwidth options, then everything is working as expected. If you need bandwidth settings for label2 to be something other than your global defaults, you will have to specify them in label2.

This behaviour is totally incorrect!
The global preferences must be applied when I add one torrent without label to Deluge.
The label preferences must be applied when I change the label of the torrent, but only the options of the label itself, no the global. The other options should stay as they are.

For example, If I change manually the upload speed and I change the label of torrent to one label that it hasn't defined speed, Deluge will change my upload speed to global upload speed!! Why!? It makes no sense!
Indeed, the sense of not set an option in the label preferences is that Deluge respects that value in the torrent and it doesn't change unless the label options to force its.
If when I change one torrent of label, Deluge applies all options (global and local), Deluge isn't respecting the particular preferences of torrent.

[Chase]

This change was made so that if you apply a label that overrides global settings, then remove the label, your settings will revert to default, since the label no longer applies to that torrent. So, if you manually set some options of a torrent, then apply a label to it, none of your changes will be lost, except for the ones that the label explicitly overrides. The only time that globals will overwrite your custom changes is if you apply a label that changes settings, manually change one of those settings, and then remove the label or change to a different label. It is assumed that this will not happen often.

[simonbcn]

ok, it's true.