Combine Resume and Pause buttons in GTK UI

[K900]

Well, that's it. Why have two buttons when you can have one? I'll make a patch for it soon and upload it here.

[Damien Churchill]

This should be done for the web interface too.

[K900]

Why 1.4.0? I guess it's quite a simple fix, and it affects usability which is the goal for 1.3.0. There are some more of these little usability issues, though, that's a new ticket.

[Damien Churchill]

1.3 is in feature freeze or supposed to be, just waiting to find the time to fix a couple last niggling bugs then work on 1.4 will commence.

If you supply a working patch then it may get in, that would be up to andar however.

[K900]

Oh, that's ok. I'll take a look at the patch later today

[chrisbeebops]

If I highlight multiple torrents, some of which are running and some of which are paused, what state will this button take?

Two buttons are still useful.

[K900]

Well, it should go "Resume all", but some feedback will be needed for this case. And it should read "Resume all" or "Pause all" when multiple torrents are selected. Oh, guess I won't make the patch in time for 1.3.0...

[andar]

Replying to chrisbeebops:

If I highlight multiple torrents, some of which are running and some of which are paused, what state will this button take?

Two buttons are still useful.

That's why we have two buttons. The code can get a bit complicated when trying to figure out which state each selected torrent is in and then the appropriate behaviour of the button. Having both buttons available is just the easiest way to do things.

[K900]

I agree that it's the easiest way, yet it is not very good in terms of usability. My personal opinion is that usability goes before code, so I am still in favor of having one button. As a less code-heavy way one of the buttons could become disabled when you select a torrent.

[Calum]

I have to say there a lot of other GTK requests that need attention when looking through the ticket system.