Opened 12 years ago

Closed 7 years ago

#1345 closed feature-request (WontFix)

Combine Resume and Pause buttons in GTK UI

Reported by: K900 Owned by:
Priority: trivial Milestone: Future
Component: GTK UI Version: 1.3.0_dev
Keywords: play, pause Cc:

Description

Well, that's it. Why have two buttons when you can have one? I'll make a patch for it soon and upload it here.

Change History (11)

comment:1 Changed 12 years ago by damoxc

  • Milestone changed from 1.3.0 to 1.4.0

This should be done for the web interface too.

comment:2 Changed 12 years ago by K900

Why 1.4.0? I guess it's quite a simple fix, and it affects usability which is the goal for 1.3.0. There are some more of these little usability issues, though, that's a new ticket.

comment:3 Changed 12 years ago by damoxc

1.3 is in feature freeze or supposed to be, just waiting to find the time to fix a couple last niggling bugs then work on 1.4 will commence.

If you supply a working patch then it may get in, that would be up to andar however.

comment:4 Changed 12 years ago by K900

Oh, that's ok. I'll take a look at the patch later today

comment:5 follow-up: Changed 12 years ago by chrisbeebops

If I highlight multiple torrents, some of which are running and some of which are paused, what state will this button take?

Two buttons are still useful.

comment:6 Changed 12 years ago by K900

  • Keywords pause added; paus removed
  • Status changed from new to pending

Well, it should go "Resume all", but some feedback will be needed for this case. And it should read "Resume all" or "Pause all" when multiple torrents are selected. Oh, guess I won't make the patch in time for 1.3.0...

comment:7 in reply to: ↑ 5 Changed 12 years ago by andar

Replying to chrisbeebops:

If I highlight multiple torrents, some of which are running and some of which are paused, what state will this button take?

Two buttons are still useful.

That's why we have two buttons. The code can get a bit complicated when trying to figure out which state each selected torrent is in and then the appropriate behaviour of the button. Having both buttons available is just the easiest way to do things.

comment:8 Changed 12 years ago by K900

  • Status changed from pending to new

I agree that it's the easiest way, yet it is not very good in terms of usability. My personal opinion is that usability goes before code, so I am still in favor of having one button. As a less code-heavy way one of the buttons could become disabled when you select a torrent.

comment:9 Changed 12 years ago by Cas

  • Priority changed from minor to trivial

I have to say there a lot of other GTK requests that need attention when looking through the ticket system.

comment:10 Changed 9 years ago by bro

  • Milestone changed from 1.4.0 to Future

comment:11 Changed 7 years ago by Cas

  • Resolution set to WontFix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.